public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-4972] ada: output.adb: fix newline being inserted when buffer is full
@ 2023-01-03  9:34 Marc Poulhi?s
  0 siblings, 0 replies; only message in thread
From: Marc Poulhi?s @ 2023-01-03  9:34 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:238ff612f2fd88372c585753dd2faa73cb94cbb5

commit r13-4972-g238ff612f2fd88372c585753dd2faa73cb94cbb5
Author: Ghjuvan Lacambre <lacambre@adacore.com>
Date:   Thu Dec 8 09:58:28 2022 +0100

    ada: output.adb: fix newline being inserted when buffer is full
    
    Before this commit, when GNAT needed to emit lines longer than
    the buffer, it accidentally inserted a newline in its output when
    attempting to flush its buffer.
    
    We fix this by using Flush_Buffer instead of Write_Eol in Write_Char.
    
    gcc/ada/
    
            * output.adb (Write_Buffer): Use Flush_Buffer instead of Write_Eol.

Diff:
---
 gcc/ada/output.adb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/ada/output.adb b/gcc/ada/output.adb
index 33d027ded8e..497643d17ec 100644
--- a/gcc/ada/output.adb
+++ b/gcc/ada/output.adb
@@ -422,10 +422,10 @@ package body Output is
 
    procedure Write_Char (C : Character) is
    begin
-      pragma Assert (Next_Col in Buffer'Range);
-      if Next_Col = Buffer'Length then
-         Write_Eol;
+      if Next_Col > Buffer'Length then
+         Flush_Buffer;
       end if;
+      pragma Assert (Next_Col in Buffer'Range);
 
       if C = ASCII.LF then
          Write_Eol;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-03  9:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-03  9:34 [gcc r13-4972] ada: output.adb: fix newline being inserted when buffer is full Marc Poulhi?s

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).