public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Meissner <meissner@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/meissner/heads/dmf007)] Update ChangeLog.meissner
Date: Wed,  1 Feb 2023 03:10:26 +0000 (GMT)	[thread overview]
Message-ID: <20230201031026.891D938582A3@sourceware.org> (raw)

https://gcc.gnu.org/g:3f0725b61d02f647c03378cd536e83796212aef0

commit 3f0725b61d02f647c03378cd536e83796212aef0
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Tue Jan 31 22:10:23 2023 -0500

    Update ChangeLog.meissner

Diff:
---
 gcc/ChangeLog.meissner | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner
index a0d78e0f5aa..c361afa4260 100644
--- a/gcc/ChangeLog.meissner
+++ b/gcc/ChangeLog.meissner
@@ -1,3 +1,31 @@
+==================== dmf007, patch #38 ====================
+
+Bump up precision size to 11 bits.
+
+The new __dmr type that is being added as a possible future PowerPC instruction
+set bumps into a structure field size issue.  The size of the __dmr type is 1024 bits.
+The precision field in tree_type_common is currently 10 bits, so if you store
+1,024 into field, you get a 0 back.  When you get 0 in the precision field, the
+ccp pass passes this 0 to sext_hwi in hwint.h.  That function in turn generates
+a shift that is equal to the host wide int bit size, which is undefined as
+machine dependent for shifting in C/C++.
+
+      int shift = HOST_BITS_PER_WIDE_INT - prec;
+      return ((HOST_WIDE_INT) ((unsigned HOST_WIDE_INT) src << shift)) >> shift;
+
+It turns out the x86_64 where I first did my tests returns the original input
+before the two shifts, while the PowerPC always returns 0.  In the ccp pass, the
+original input is -1, and so it worked.  When I did the runs on the PowerPC, the
+result was 0, which ultimately led to the failure.
+
+2023-01-31   Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* hwint.h (sext_hwi): Add assertion against precision 0.
+	* tree-core.h (tree_type_common): Bump up precision field by 1 bit, and
+	reduce contains_placeholder_bits to 1 bit.
+
 ==================== dmf007, patch #37 ====================
 
 Support load/store vector with right length.

             reply	other threads:[~2023-02-01  3:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01  3:10 Michael Meissner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-02-02  2:59 Michael Meissner
2023-02-01 17:35 Michael Meissner
2023-02-01  6:28 Michael Meissner
2023-01-28  7:14 Michael Meissner
2023-01-28  3:21 Michael Meissner
2023-01-23 21:19 Michael Meissner
2023-01-23 21:19 Michael Meissner
2023-01-23 21:18 Michael Meissner
2023-01-21  3:27 Michael Meissner
2023-01-20 22:22 Michael Meissner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230201031026.891D938582A3@sourceware.org \
    --to=meissner@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).