public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/rust/master] expander: Add documentation for `expand_eager_invocations`
@ 2023-02-13 12:02 Thomas Schwinge
0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2023-02-13 12:02 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:f67f5409d2fe4191ab24b5eb634c26306386fb25
commit f67f5409d2fe4191ab24b5eb634c26306386fb25
Author: Arthur Cohen <arthur.cohen@embecosm.com>
Date: Wed Feb 8 12:23:06 2023 +0100
expander: Add documentation for `expand_eager_invocations`
gcc/rust/ChangeLog:
* expand/rust-macro-expand.cc (MacroExpander::expand_eager_invocations):
Add documentation explaining the algorithm.
Diff:
---
gcc/rust/expand/rust-macro-expand.cc | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/gcc/rust/expand/rust-macro-expand.cc b/gcc/rust/expand/rust-macro-expand.cc
index 1684c2ba16f..597cb6a4844 100644
--- a/gcc/rust/expand/rust-macro-expand.cc
+++ b/gcc/rust/expand/rust-macro-expand.cc
@@ -197,17 +197,25 @@ MacroExpander::expand_eager_invocations (AST::MacroInvocation &invoc)
auto start = kv.first.first;
auto end = kv.first.second;
- // TODO: Add doc
+ // We're now going to re-add the tokens to the invocation's token tree.
+ // 1. Basically, what we want to do is insert all tokens up until the
+ // beginning of the macro invocation (start).
+ // 2. Then, we'll insert all of the tokens resulting from the macro
+ // expansion: These are in `new_tokens`.
+ // 3. Finally, we'll do that again from
+ // the end of macro and go back to 1.
+
for (size_t i = current_idx; i < start; i++)
new_stream.emplace_back (stream[i]->clone_token ());
- // TODO: Add doc
for (auto &tok : new_tokens)
new_stream.emplace_back (tok->clone_token ());
current_idx = end;
}
- // TODO: Add doc
+
+ // Once all of that is done, we copy the last remaining tokens from the
+ // original stream
for (size_t i = current_idx; i < stream.size (); i++)
new_stream.emplace_back (stream[i]->clone_token ());
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-13 12:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 12:02 [gcc/devel/rust/master] expander: Add documentation for `expand_eager_invocations` Thomas Schwinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).