public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/pheeck/heads/sccp)] Fix recent rvv/base/spill testcase failures
@ 2023-02-15 10:20 Filip Kastl
0 siblings, 0 replies; only message in thread
From: Filip Kastl @ 2023-02-15 10:20 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:945b8973396457acecca830443027733953cc84a
commit 945b8973396457acecca830443027733953cc84a
Author: Jeff Law <jeffreyalaw@gmail.com>
Date: Tue Nov 22 18:12:45 2022 -0500
Fix recent rvv/base/spill testcase failures
he core issue is we're expecting the frame to have a constant size, but it
doesn't. So when using the to_constant method we abort.
The safest thing to do is to set no shrink-wrapping components when the
frame size is not fixed. We might be able to do better later -- iff we
know the offset to the GPRs/FPRs is fixed and fits into the appropriate
number of bits.
Bootstrapped and regression tested (C-only) on riscv64-linux-gnu. As
expected, it fixes a bucketload of failures in rvv/base/spill-*.c.
gcc/
* config/riscv/riscv.cc (riscv_get_separate_components): Do not
do shrink-wrapping for a frame with a variable size.
Diff:
---
gcc/config/riscv/riscv.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 7ec4ce97e6c..7bfc0e9f595 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -5340,7 +5340,8 @@ riscv_get_separate_components (void)
bitmap_clear (components);
if (riscv_use_save_libcall (&cfun->machine->frame)
- || cfun->machine->interrupt_handler_p)
+ || cfun->machine->interrupt_handler_p
+ || !cfun->machine->frame.gp_sp_offset.is_constant ())
return components;
offset = cfun->machine->frame.gp_sp_offset.to_constant ();
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-15 10:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-15 10:20 [gcc(refs/users/pheeck/heads/sccp)] Fix recent rvv/base/spill testcase failures Filip Kastl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).