public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-6001] libgomp: Fix reverse-offload for GOMP_MAP_TO_PSET
@ 2023-02-15 10:21 Tobias Burnus
  0 siblings, 0 replies; only message in thread
From: Tobias Burnus @ 2023-02-15 10:21 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:edaf1d607860075c5ff4ade20c58b3f578ed5489

commit r13-6001-gedaf1d607860075c5ff4ade20c58b3f578ed5489
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Wed Feb 15 11:20:32 2023 +0100

    libgomp: Fix reverse-offload for GOMP_MAP_TO_PSET
    
    libgomp/
            * target.c (gomp_target_rev): Dereference ptr
            to get device address.
            * testsuite/libgomp.fortran/reverse-offload-5.f90: Add test
            for unallocated allocatable.

Diff:
---
 libgomp/target.c                                        | 8 +++++++-
 libgomp/testsuite/libgomp.fortran/reverse-offload-5.f90 | 6 ++++--
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/libgomp/target.c b/libgomp/target.c
index b4ea2c559c8..483851c95ac 100644
--- a/libgomp/target.c
+++ b/libgomp/target.c
@@ -3580,8 +3580,14 @@ gomp_target_rev (uint64_t fn_ptr, uint64_t mapnum, uint64_t devaddrs_ptr,
 		      }
 		    int k;
 		    n2 = NULL;
-		    cdata[i].present = true;
+		    /* Dereference devaddrs[j] to get the device addr.  */
+		    assert (devaddrs[j] - sizes[j] == cdata[i].devaddr);
+		    devaddrs[j] = *(uint64_t *) (uintptr_t) (devaddrs[i]
+							     + sizes[j]);
+		    cdata[j].present = true;
 		    cdata[j].devaddr = devaddrs[j];
+		    if (devaddrs[j] == 0)
+		      continue;
 		    k = gomp_map_cdata_lookup (cdata, devaddrs, kinds, sizes, j,
 					       devaddrs[j],
 					       devaddrs[j] + sizeof (void*),
diff --git a/libgomp/testsuite/libgomp.fortran/reverse-offload-5.f90 b/libgomp/testsuite/libgomp.fortran/reverse-offload-5.f90
index ef7eb7bdd52..16810eb47de 100644
--- a/libgomp/testsuite/libgomp.fortran/reverse-offload-5.f90
+++ b/libgomp/testsuite/libgomp.fortran/reverse-offload-5.f90
@@ -24,7 +24,7 @@ s2 = 55
 
 !$omp target map(to: A, A2, s1, s2)
 block
-  integer, allocatable :: ai(:), ai2(:), si1, si2
+  integer, allocatable :: ai(:), ai2(:), ai3(:), si1, si2, si3
 
   a = a * 2
   a2 = a2 * 3
@@ -38,7 +38,7 @@ block
 
   !$omp target device (ancestor:1)  &
   !$omp&       map(to: A, s1, ai, si1) map(always, to: a2, s2)  &
-  !$omp&       map(tofrom: ai2, si2)
+  !$omp&       map(tofrom: ai2, si2, ai3, si3)
     if (shared_mem) then
       if (any (a  /= 2 * [1,2,3,4])) stop 1
       if (s1 /= 4 * 532) stop 2
@@ -52,6 +52,7 @@ block
     if (any (ai2 /= [8,4,7,1])) stop 8
     if (si1 /= 64) stop 9
     if (si2 /= 765) stop 10
+    if (allocated (ai3) .or. allocated(si3)) stop 26
 
     a = a*3
     a2 = a2*7
@@ -80,6 +81,7 @@ block
   endif
   if (any (ai2 /= 21 * [8,4,7,1])) stop 24
   if (si2 /= 31 * 765) stop 25
+  if (allocated (ai3) .or. allocated(si3)) stop 27
 
   deallocate (ai, ai2, si1, si2)
 end block

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-15 10:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-15 10:21 [gcc r13-6001] libgomp: Fix reverse-offload for GOMP_MAP_TO_PSET Tobias Burnus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).