public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6364] testsuite: Add -fno-ivopts to gcc.dg/Wuse-after-free-2.c, PR108828 Date: Tue, 28 Feb 2023 01:05:02 +0000 (GMT) [thread overview] Message-ID: <20230228010503.009C23858D32@sourceware.org> (raw) https://gcc.gnu.org/g:8c58f4b798177d419c5af37b7e23c490849f2d45 commit r13-6364-g8c58f4b798177d419c5af37b7e23c490849f2d45 Author: Hans-Peter Nilsson <hp@axis.com> Date: Fri Feb 24 17:22:02 2023 +0100 testsuite: Add -fno-ivopts to gcc.dg/Wuse-after-free-2.c, PR108828 For cris-elf before this patch, ever since it was added, this test gets: Running /x/gcc/testsuite/gcc.dg/dg.exp ... FAIL: gcc.dg/Wuse-after-free-2.c (test for warnings, line 115) FAIL: gcc.dg/Wuse-after-free-2.c (test for warnings, line 116) and comparing tree dumps with a native x86_64-pc-linux-gnu run shows a suspicious difference in the "180t.ivopts" dump. Indeed -fno-ivopts makes the warning appear for cris-elf too. It was suggested to simply add -fno-ivopts to the test-flags, like before -fno-tree-loop-distribute-patterns was added; thus. PR tree-optimization/108828 * gcc.dg/Wuse-after-free-2.c: Add -fno-ivopts. Diff: --- gcc/testsuite/gcc.dg/Wuse-after-free-2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.dg/Wuse-after-free-2.c b/gcc/testsuite/gcc.dg/Wuse-after-free-2.c index 68ec75845ce..ebc051690db 100644 --- a/gcc/testsuite/gcc.dg/Wuse-after-free-2.c +++ b/gcc/testsuite/gcc.dg/Wuse-after-free-2.c @@ -1,6 +1,6 @@ /* PR middle-end/104232 - spurious -Wuse-after-free after conditional free { dg-do compile } - { dg-options "-O2 -Wall -fno-tree-loop-distribute-patterns" } */ + { dg-options "-O2 -Wall -fno-tree-loop-distribute-patterns -fno-ivopts" } */ void free (void*); @@ -108,7 +108,8 @@ int warn_cond_loop (char *p) char *q = p; /* -fno-tree-loop-distribute-patterns ensures this does not get converted - into rawmemchr (making q and p unrelated). */ + into rawmemchr (making q and p unrelated). Also, -fno-ivopts is required + for some targets, to not lose track of the pointer. */ while (*q) ++q;
reply other threads:[~2023-02-28 1:05 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230228010503.009C23858D32@sourceware.org \ --to=hp@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).