public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-6382] testsuite: Fix analyzer errors for newlib-fd
@ 2023-03-01  1:39 Hans-Peter Nilsson
  0 siblings, 0 replies; only message in thread
From: Hans-Peter Nilsson @ 2023-03-01  1:39 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:6622f7e8b896071cc554774171353cc82a4a3a5f

commit r13-6382-g6622f7e8b896071cc554774171353cc82a4a3a5f
Author: Hans-Peter Nilsson <hp@axis.com>
Date:   Tue Feb 28 18:37:32 2023 +0100

    testsuite: Fix analyzer errors for newlib-fd
    
    Investigating analyzer testsuite errors for cris-elf.  The same are
    seen for pru-elf according to posts to gcc-testresults@.
    
    The test fd-access-mode-target-headers.c uses the analyzer
    "sm-fd" which for this use requires (e.g.) that constants
    O_ACCMODE, O_RDONLY and O_WRONLY are defined as literal
    constants.  While for glibc, O_ACCMODE is defined as:
     #define O_ACCMODE 0003
    in newlib, it's defined as:
     #define O_ACCMODE (O_RDONLY|O_WRONLY|O_RDWR)
    and the analyzer is not able to make use of an expression
    like this (even though O_RDONLY, O_WRONLY and O_RDWR are
    defined as literal constants and the whole evaluates to 3).
    Better do as for AIX and skip this test.
    
    testsuite:
            * gcc.dg/analyzer/fd-access-mode-target-headers.c: Skip for
            newlib targets too.

Diff:
---
 gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c b/gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c
index 847d47e0634..cf273b217d1 100644
--- a/gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c
+++ b/gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c
@@ -1,4 +1,4 @@
-/* { dg-skip-if "" { powerpc*-*-aix* } } */
+/* { dg-skip-if "" { powerpc*-*-aix* || newlib } } */
 
 #include <sys/stat.h>
 #include <fcntl.h>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-01  1:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-01  1:39 [gcc r13-6382] testsuite: Fix analyzer errors for newlib-fd Hans-Peter Nilsson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).