public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Andre Simoes Dias Vieira <avieira@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-6415] simplify-rtx: Use byte in simplify_subreg rather than assume 0 offset Date: Thu, 2 Mar 2023 14:12:34 +0000 (GMT) [thread overview] Message-ID: <20230302141234.802EC3858CDB@sourceware.org> (raw) https://gcc.gnu.org/g:61407e018940633a9ca997bf3773f794faa25e23 commit r13-6415-g61407e018940633a9ca997bf3773f794faa25e23 Author: Andre Vieira <andre.simoesdiasvieira@arm.com> Date: Thu Mar 2 14:11:59 2023 +0000 simplify-rtx: Use byte in simplify_subreg rather than assume 0 offset This patch fixes a missed review comment in an earlier patch using byte instead of a 0 offset. Also improves the comment as suggested. gcc/ChangeLog: * simplify-rtx.cc (simplify_context::simplify_subreg): Use byte instead of constant 0 offset. Diff: --- gcc/simplify-rtx.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/simplify-rtx.cc b/gcc/simplify-rtx.cc index 2c82256af66..3b33afa2461 100644 --- a/gcc/simplify-rtx.cc +++ b/gcc/simplify-rtx.cc @@ -7667,10 +7667,10 @@ simplify_context::simplify_subreg (machine_mode outermode, rtx op, } } - /* Try simplifying a SUBREG expression of a non-integer OUTERMODE by using a - NEW_OUTERMODE of the same size instead, other simplifications rely on - integer to integer subregs and we'd potentially miss out on optimizations - otherwise. */ + /* If the outer mode is not integral, try taking a subreg with the equivalent + integer outer mode and then bitcasting the result. + Other simplifications rely on integer to integer subregs and we'd + potentially miss out on optimizations otherwise. */ if (known_gt (GET_MODE_SIZE (innermode), GET_MODE_SIZE (outermode)) && SCALAR_INT_MODE_P (innermode) @@ -7680,7 +7680,7 @@ simplify_context::simplify_subreg (machine_mode outermode, rtx op, { rtx tem = simplify_subreg (int_outermode, op, innermode, byte); if (tem) - return simplify_gen_subreg (outermode, tem, int_outermode, 0); + return simplify_gen_subreg (outermode, tem, int_outermode, byte); } /* If OP is a vector comparison and the subreg is not changing the
reply other threads:[~2023-03-02 14:12 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230302141234.802EC3858CDB@sourceware.org \ --to=avieira@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).