public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-6415] simplify-rtx: Use byte in simplify_subreg rather than assume 0 offset
@ 2023-03-02 14:12 Andre Simoes Dias Vieira
  0 siblings, 0 replies; only message in thread
From: Andre Simoes Dias Vieira @ 2023-03-02 14:12 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:61407e018940633a9ca997bf3773f794faa25e23

commit r13-6415-g61407e018940633a9ca997bf3773f794faa25e23
Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Date:   Thu Mar 2 14:11:59 2023 +0000

    simplify-rtx: Use byte in simplify_subreg rather than assume 0 offset
    
    This patch fixes a missed review comment in an earlier patch using byte instead
    of a 0 offset.  Also improves the comment as suggested.
    
    gcc/ChangeLog:
    
            * simplify-rtx.cc (simplify_context::simplify_subreg): Use byte instead
            of constant 0 offset.

Diff:
---
 gcc/simplify-rtx.cc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gcc/simplify-rtx.cc b/gcc/simplify-rtx.cc
index 2c82256af66..3b33afa2461 100644
--- a/gcc/simplify-rtx.cc
+++ b/gcc/simplify-rtx.cc
@@ -7667,10 +7667,10 @@ simplify_context::simplify_subreg (machine_mode outermode, rtx op,
 	}
     }
 
-  /* Try simplifying a SUBREG expression of a non-integer OUTERMODE by using a
-     NEW_OUTERMODE of the same size instead, other simplifications rely on
-     integer to integer subregs and we'd potentially miss out on optimizations
-     otherwise.  */
+  /* If the outer mode is not integral, try taking a subreg with the equivalent
+     integer outer mode and then bitcasting the result.
+     Other simplifications rely on integer to integer subregs and we'd
+     potentially miss out on optimizations otherwise.  */
   if (known_gt (GET_MODE_SIZE (innermode),
 		GET_MODE_SIZE (outermode))
       && SCALAR_INT_MODE_P (innermode)
@@ -7680,7 +7680,7 @@ simplify_context::simplify_subreg (machine_mode outermode, rtx op,
     {
       rtx tem = simplify_subreg (int_outermode, op, innermode, byte);
       if (tem)
-	return simplify_gen_subreg (outermode, tem, int_outermode, 0);
+	return simplify_gen_subreg (outermode, tem, int_outermode, byte);
     }
 
   /* If OP is a vector comparison and the subreg is not changing the

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-02 14:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-02 14:12 [gcc r13-6415] simplify-rtx: Use byte in simplify_subreg rather than assume 0 offset Andre Simoes Dias Vieira

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).