public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc/devel/rust/master] gccrs: destructure parameter names.
Date: Sun,  5 Mar 2023 11:42:30 +0000 (GMT)	[thread overview]
Message-ID: <20230305114230.5837F385840A@sourceware.org> (raw)

https://gcc.gnu.org/g:22465fbc8cca239aadcb35cd51d820d6d7213238

commit 22465fbc8cca239aadcb35cd51d820d6d7213238
Author: Philip Herron <herron.philip@googlemail.com>
Date:   Fri Mar 3 16:12:46 2023 +0000

    gccrs: destructure parameter names.
    
    When we have complex generic code you can end up with situations where we
    compile types:
    
      Maybe<<S as Foo>::A>
    
    Into
    
      Maybe<<placeholder:<Projection=::()>>>
    
    This calls destructure to cleanup the naming here and avoid making non
    canonical TREE_TYPES hitting the verify_gimple code triggering non-trival
    constructors.
    
    Signed-off-by: Philip Herron <herron.philip@googlemail.com>
    
    gcc/rust/ChangeLog:
    
            * typecheck/rust-tyty.cc (ParamType::get_name): call destructure

Diff:
---
 gcc/rust/typecheck/rust-tyty.cc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gcc/rust/typecheck/rust-tyty.cc b/gcc/rust/typecheck/rust-tyty.cc
index 110f59266f3..e6dfc561fbf 100644
--- a/gcc/rust/typecheck/rust-tyty.cc
+++ b/gcc/rust/typecheck/rust-tyty.cc
@@ -18,10 +18,7 @@
 
 #include "rust-tyty.h"
 
-#include "rust-hir-type-check-expr.h"
-#include "rust-hir-type-check-type.h"
 #include "rust-tyty-visitor.h"
-#include "rust-tyty-call.h"
 #include "rust-hir-map.h"
 #include "rust-location.h"
 #include "rust-linemap.h"
@@ -2961,7 +2958,7 @@ ParamType::get_name () const
   if (!can_resolve ())
     return get_symbol ();
 
-  return resolve ()->get_name ();
+  return destructure ()->get_name ();
 }
 
 bool

                 reply	other threads:[~2023-03-05 11:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230305114230.5837F385840A@sourceware.org \
    --to=tschwinge@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).