public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/rust/master] gccrs: destructure parameter names.
@ 2023-03-05 11:42 Thomas Schwinge
  0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2023-03-05 11:42 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:22465fbc8cca239aadcb35cd51d820d6d7213238

commit 22465fbc8cca239aadcb35cd51d820d6d7213238
Author: Philip Herron <herron.philip@googlemail.com>
Date:   Fri Mar 3 16:12:46 2023 +0000

    gccrs: destructure parameter names.
    
    When we have complex generic code you can end up with situations where we
    compile types:
    
      Maybe<<S as Foo>::A>
    
    Into
    
      Maybe<<placeholder:<Projection=::()>>>
    
    This calls destructure to cleanup the naming here and avoid making non
    canonical TREE_TYPES hitting the verify_gimple code triggering non-trival
    constructors.
    
    Signed-off-by: Philip Herron <herron.philip@googlemail.com>
    
    gcc/rust/ChangeLog:
    
            * typecheck/rust-tyty.cc (ParamType::get_name): call destructure

Diff:
---
 gcc/rust/typecheck/rust-tyty.cc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gcc/rust/typecheck/rust-tyty.cc b/gcc/rust/typecheck/rust-tyty.cc
index 110f59266f3..e6dfc561fbf 100644
--- a/gcc/rust/typecheck/rust-tyty.cc
+++ b/gcc/rust/typecheck/rust-tyty.cc
@@ -18,10 +18,7 @@
 
 #include "rust-tyty.h"
 
-#include "rust-hir-type-check-expr.h"
-#include "rust-hir-type-check-type.h"
 #include "rust-tyty-visitor.h"
-#include "rust-tyty-call.h"
 #include "rust-hir-map.h"
 #include "rust-location.h"
 #include "rust-linemap.h"
@@ -2961,7 +2958,7 @@ ParamType::get_name () const
   if (!can_resolve ())
     return get_symbol ();
 
-  return resolve ()->get_name ();
+  return destructure ()->get_name ();
 }
 
 bool

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-05 11:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-05 11:42 [gcc/devel/rust/master] gccrs: destructure parameter names Thomas Schwinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).