public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/omp/gcc-12] OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait'
@ 2023-03-10 14:45 Thomas Schwinge
0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2023-03-10 14:45 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:e58692d95d36ed9b466a1925cae38eb5318bc25e
commit e58692d95d36ed9b466a1925cae38eb5318bc25e
Author: Thomas Schwinge <thomas@codesourcery.com>
Date: Fri Feb 24 16:17:57 2023 +0100
OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait'
We're not taking such a shortcut anywhere else, and (with future changes) it
has potential to confuse things if synchronization in a libgomp plugin happens
to have side effects even if an async queue currently is empty.
libgomp/
* oacc-async.c (goacc_wait): Remove 'acc_async_test' -> skip
shortcut.
(cherry picked from commit b5037d4a073f2e4625afab5ec1f35624d9f9eba1)
Diff:
---
libgomp/ChangeLog.omp | 6 ++++++
libgomp/oacc-async.c | 3 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp
index 402b14311a8..da11f40651f 100644
--- a/libgomp/ChangeLog.omp
+++ b/libgomp/ChangeLog.omp
@@ -3,6 +3,12 @@
Backported from master:
2023-03-10 Thomas Schwinge <thomas@codesourcery.com>
+ * oacc-async.c (goacc_wait): Remove 'acc_async_test' -> skip
+ shortcut.
+
+ Backported from master:
+ 2023-03-10 Thomas Schwinge <thomas@codesourcery.com>
+
* testsuite/libgomp.oacc-c-c++-common/data-3.c: Document/verify
another aspect of OpenACC 'async' semantics.
diff --git a/libgomp/oacc-async.c b/libgomp/oacc-async.c
index 026df3c9417..b00f45d5754 100644
--- a/libgomp/oacc-async.c
+++ b/libgomp/oacc-async.c
@@ -410,9 +410,6 @@ goacc_wait (int async, int num_waits, va_list *ap)
break;
}
- if (acc_async_test (qid))
- continue;
-
if (async == acc_async_sync)
acc_wait (qid);
else if (qid == async)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-10 14:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-10 14:45 [gcc/devel/omp/gcc-12] OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait' Thomas Schwinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).