public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-6852] Add caveat/safeguard to OpenMP: Handle descriptors in target's firstprivate [PR104949]
@ 2023-03-24 16:16 Thomas Schwinge
  0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2023-03-24 16:16 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:e8fec6998b656dac02d4bc6c69b35a0fb5611e87

commit r13-6852-ge8fec6998b656dac02d4bc6c69b35a0fb5611e87
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Thu Mar 23 12:32:35 2023 +0100

    Add caveat/safeguard to OpenMP: Handle descriptors in target's firstprivate [PR104949]
    
    Follow-up to commit 49d1a2f91325fa8cc011149e27e5093a988b3a49
    "OpenMP: Handle descriptors in target's firstprivate [PR104949]".
    
            PR fortran/104949
            libgomp/
            * target.c (gomp_map_vars_internal) <GOMP_MAP_FIRSTPRIVATE>: Add
            caveat/safeguard.

Diff:
---
 libgomp/target.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libgomp/target.c b/libgomp/target.c
index 90b4204133a..b30c6a50c7e 100644
--- a/libgomp/target.c
+++ b/libgomp/target.c
@@ -1396,6 +1396,11 @@ gomp_map_vars_internal (struct gomp_device_descr *devicep,
 		  {
 		    uintptr_t target = (uintptr_t) hostaddrs[i];
 		    void *devptr = *(void**) hostaddrs[i+1] + sizes[i+1];
+		    /* Per
+		       <https://inbox.sourceware.org/gcc-patches/87o7pe12ke.fsf@euler.schwinge.homeip.net>
+		       "OpenMP: Handle descriptors in target's firstprivate [PR104949]"
+		       this probably needs revision for 'aq' usage.  */
+		    assert (!aq);
 		    gomp_copy_host2dev (devicep, aq, devptr, &target,
 					sizeof (void *), false, cbufp);
 		    ++i;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-24 16:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 16:16 [gcc r13-6852] Add caveat/safeguard to OpenMP: Handle descriptors in target's firstprivate [PR104949] Thomas Schwinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).