public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/meissner/heads/work116)] Update ChangeLog.*
@ 2023-03-24 21:31 Michael Meissner
0 siblings, 0 replies; 3+ messages in thread
From: Michael Meissner @ 2023-03-24 21:31 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:557eb70f26250a523022edf3b043190875b1cfa7
commit 557eb70f26250a523022edf3b043190875b1cfa7
Author: Michael Meissner <meissner@linux.ibm.com>
Date: Fri Mar 24 17:31:09 2023 -0400
Update ChangeLog.*
Diff:
---
gcc/ChangeLog.meissner | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner
index 489c3307113..b0bbf1a43f1 100644
--- a/gcc/ChangeLog.meissner
+++ b/gcc/ChangeLog.meissner
@@ -1,3 +1,47 @@
+==================== Branch work116, patch #1 ====================
+
+Make load/cmp fusion know about prefixed loads.
+
+The issue with the bug is the power10 load GPR + cmpi -1/0/1 fusion
+optimization generates illegal assembler code.
+
+Ultimately the code was dying because the fusion load + compare -1/0/1 patterns
+did not handle the possibility that the load might be prefixed.
+
+The main cause is the constraints for the individual loads in the fusion did not
+match the machine. In particular, LWA is a ds format instruction when it is
+unprefixed. The code did not also set the prefixed attribute correctly.
+
+This patch rewrites the genfusion.pl script so that it will have more accurate
+constraints for the LWA and LD instructions (which are DS instructions). The
+updated genfusion.pl was then run to update fusion.md. Finally, the code for
+the "prefixed" attribute is modified so that it considers load + compare
+immediate patterns to be like the normal load insns in checking whether
+operand[1] is a prefixed instruction.
+
+I posted a version of patch on March 21st. This patch makes some code changes
+suggested in the genfusion.pl code.
+
+2023-03-21 Michael Meissner <meissner@linux.ibm.com>
+
+gcc/
+
+ PR target/105325
+ * gcc/config/rs6000/genfusion.pl (gen_ld_cmpi_p10): Improve generation
+ of the ld and lwa instructions which use the DS encoding instead of D.
+ Use the YZ constraint for these loads. Handle prefixed loads better.
+ Set the sign_extend attribute as appropriate.
+ * gcc/config/rs6000/fusion.md: Regenerate.
+ * gcc/config/rs6000/rs6000.md (prefixed attribute): Add fused_load_cmpi
+ instructions to the list of instructions that might have a prefixed load
+ instruction.
+
+gcc/testsuite/
+
+ PR target/105325
+ * g++.target/powerpc/pr105325.C: New test.
+ * gcc.target/powerpc/fusion-p10-ldcmpi.c: Adjust insn counts.
+
==================== Branch work116, baseline ====================
2023-03-24 Michael Meissner <meissner@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [gcc(refs/users/meissner/heads/work116)] Update ChangeLog.*
@ 2023-03-28 20:12 Michael Meissner
0 siblings, 0 replies; 3+ messages in thread
From: Michael Meissner @ 2023-03-28 20:12 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:e1bb8baafe64038aacf530c240092ed5ede0ec3a
commit e1bb8baafe64038aacf530c240092ed5ede0ec3a
Author: Michael Meissner <meissner@linux.ibm.com>
Date: Tue Mar 28 16:12:30 2023 -0400
Update ChangeLog.*
Diff:
---
gcc/ChangeLog.meissner | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner
index 62556895b5c..d8981e78cf5 100644
--- a/gcc/ChangeLog.meissner
+++ b/gcc/ChangeLog.meissner
@@ -1,4 +1,4 @@
-==================== Branch work116, patch #1 ====================
+==================== Branch work116, patch #2 ====================
Make load/cmp fusion know about prefixed loads.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [gcc(refs/users/meissner/heads/work116)] Update ChangeLog.*
@ 2023-03-28 20:12 Michael Meissner
0 siblings, 0 replies; 3+ messages in thread
From: Michael Meissner @ 2023-03-28 20:12 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:4de71cc9bd14b6683786e004a6fa801089a79ed4
commit 4de71cc9bd14b6683786e004a6fa801089a79ed4
Author: Michael Meissner <meissner@linux.ibm.com>
Date: Mon Mar 27 16:04:32 2023 -0400
Update ChangeLog.*
Diff:
---
gcc/ChangeLog.meissner | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner
index b0bbf1a43f1..62556895b5c 100644
--- a/gcc/ChangeLog.meissner
+++ b/gcc/ChangeLog.meissner
@@ -19,10 +19,11 @@ the "prefixed" attribute is modified so that it considers load + compare
immediate patterns to be like the normal load insns in checking whether
operand[1] is a prefixed instruction.
-I posted a version of patch on March 21st. This patch makes some code changes
-suggested in the genfusion.pl code.
+I posted a version of patch on March 21st and a second version on March 24th.
+This patch makes some code changes suggested in the genfusion.pl code. The
+fusion.md that is produced by genfusion.pl is the same in all 3 versions.
-2023-03-21 Michael Meissner <meissner@linux.ibm.com>
+2023-03-27 Michael Meissner <meissner@linux.ibm.com>
gcc/
@@ -42,6 +43,8 @@ gcc/testsuite/
* g++.target/powerpc/pr105325.C: New test.
* gcc.target/powerpc/fusion-p10-ldcmpi.c: Adjust insn counts.
+==================== Branch work116, patch #1 was reverted ====================
+
==================== Branch work116, baseline ====================
2023-03-24 Michael Meissner <meissner@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-28 20:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 21:31 [gcc(refs/users/meissner/heads/work116)] Update ChangeLog.* Michael Meissner
2023-03-28 20:12 Michael Meissner
2023-03-28 20:12 Michael Meissner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).