public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-8] Do not export global ranges from -Walloca pass.
@ 2023-04-17 18:47 Aldy Hernandez
  0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2023-04-17 18:47 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:e11533e2f3dd91eef663f08f8326eefb72680cdf

commit r14-8-ge11533e2f3dd91eef663f08f8326eefb72680cdf
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Mon Apr 17 17:05:38 2023 +0200

    Do not export global ranges from -Walloca pass.
    
    A warning pass should not be exporting global ranges it finds along
    the way, because that will alter the behavior of future passes.
    
    The reason the present behavior was there was because of some long ago
    forgotten regression in another pass.  This regression is no longer
    there, and if there's ever any fallout from cleaning this up, we can
    address it in the pass that is missing some information.
    
    gcc/ChangeLog:
    
            * gimple-ssa-warn-alloca.cc (pass_walloca::execute): Do not export
            global ranges.

Diff:
---
 gcc/gimple-ssa-warn-alloca.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gcc/gimple-ssa-warn-alloca.cc b/gcc/gimple-ssa-warn-alloca.cc
index 5b220a5c68e..4374f572cd9 100644
--- a/gcc/gimple-ssa-warn-alloca.cc
+++ b/gcc/gimple-ssa-warn-alloca.cc
@@ -256,7 +256,7 @@ in_loop_p (gimple *stmt)
 unsigned int
 pass_walloca::execute (function *fun)
 {
-  gimple_ranger *ranger = enable_ranger (fun);
+  enable_ranger (fun);
   basic_block bb;
   FOR_EACH_BB_FN (bb, fun)
     {
@@ -379,7 +379,6 @@ pass_walloca::execute (function *fun)
 	    }
 	}
     }
-  ranger->export_global_ranges ();
   disable_ranger (fun);
   return 0;
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-04-17 18:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-17 18:47 [gcc r14-8] Do not export global ranges from -Walloca pass Aldy Hernandez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).