public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Meissner <meissner@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/meissner/heads/work119)] Fold sign or zero extension into vsx_extract from memory with variable element.
Date: Fri, 21 Apr 2023 04:21:29 +0000 (GMT)	[thread overview]
Message-ID: <20230421042129.980CE3858D20@sourceware.org> (raw)

https://gcc.gnu.org/g:74f840c6ceef5e2c92f31dfde9b23e41e9007be4

commit 74f840c6ceef5e2c92f31dfde9b23e41e9007be4
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Fri Apr 21 00:20:54 2023 -0400

    Fold sign or zero extension into vsx_extract from memory with variable element.
    
    This patch folds conversion to floating point of vsx_extract from memory of V4SI
    elements where the element number is constant.  This code optimizes things so it
    will load the integer with LFIWAX or LFIWZX directly into a vector register
    rather than loading it into a GPR and doing a direct move operation.
    
    2023-04-21   Michael Meissner  <meissner@linux.ibm.com>
    
    gcc/
    
            * config/rs6000/vsx.md (vsx_extract_v4si_var_load_to_<uns><mode>): New
            insn.
    
    gcc/testsuite/
    
            * gcc.target/powerpc/vec-extract-mem-int-4.c: New file.

Diff:
---
 gcc/config/rs6000/vsx.md                           | 30 ++++++++++++++++++++++
 .../gcc.target/powerpc/vec-extract-mem-int-4.c     | 27 +++++++++++++++++++
 2 files changed, 57 insertions(+)

diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md
index 3364a0791c2..457513a4eaa 100644
--- a/gcc/config/rs6000/vsx.md
+++ b/gcc/config/rs6000/vsx.md
@@ -4214,6 +4214,36 @@
    (set_attr "length" "12,16,16,20")
    (set_attr "isa" "*,*,p9v,p9v")])
 
+;; Extract a V4SI element from memory with variable element number and convert
+;; it to SFmode or DFmode using either signed or unsigned conversion.
+(define_insn_and_split "*vsx_extract_v4si_load_to_<uns><mode>"
+  [(set (match_operand:SFDF 0 "register_operand" "=wa,wa")
+	(any_float:SFDF
+	 (unspec:SI
+	  [(match_operand:V4SI 1 "memory_operand" "Q,Q")
+	   (match_operand:DI 2 "gpc_reg_operand" "r,r")]
+	  UNSPEC_VSX_EXTRACT)))
+   (clobber (match_scratch:DI 3 "=&b,&b"))
+   (clobber (match_scratch:DI 4 "=f,v"))]
+  "VECTOR_MEM_VSX_P (V4SImode) && TARGET_POWERPC64"
+  "#"
+  "&& 1"
+  [(set (match_dup 4)
+	(match_dup 5))
+   (set (match_dup 0)
+	(float:SFDF (match_dup 4)))]
+{
+  if (GET_CODE (operands[4]) == SCRATCH)
+    operands[4] = gen_reg_rtx (DImode);
+
+  rtx new_mem = rs6000_adjust_vec_address (operands[4], operands[1], operands[2],
+					   operands[3], SImode);
+  operands[5] = gen_rtx_<SIGN_ZERO_EXTEND> (DImode, new_mem);
+}
+  [(set_attr "type" "fpload")
+   (set_attr "length" "20")
+   (set_attr "isa" "*,p8v")])
+
 ;; ISA 3.1 extract
 (define_expand "vextractl<mode>"
   [(set (match_operand:V2DI 0 "altivec_register_operand")
diff --git a/gcc/testsuite/gcc.target/powerpc/vec-extract-mem-int-4.c b/gcc/testsuite/gcc.target/powerpc/vec-extract-mem-int-4.c
new file mode 100644
index 00000000000..415dee36d8a
--- /dev/null
+++ b/gcc/testsuite/gcc.target/powerpc/vec-extract-mem-int-4.c
@@ -0,0 +1,27 @@
+/* { dg-do compile { target lp64 } } */
+/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-options "-O2 -mdejagnu-cpu=power8" } */
+
+/* Test to verify that the vec_extract with variable element numbers can load
+   SImode and convert the value to float, and double by loading the value
+   directly into a vector register, and not loading up the GPRs first.  */
+
+#include <altivec.h>
+#include <stddef.h>
+
+float
+extract_float_sign_v4si_var (vector int *p, size_t n)
+{
+  return vec_extract (*p, n);		/* lfiwax or lxsiwax.  */
+}
+
+double
+extract_double_uns_v4si_var (vector unsigned int *p, size_t n)
+{
+  return vec_extract (*p, n);		/* lfiwzx or lxsiwzx.  */
+}
+
+/* { dg-final { scan-assembler-times {\mlfiwax\M|\mlxsiwax\M}  1 } } */
+/* { dg-final { scan-assembler-times {\mlfiwzx\M|\mlxsiwzx\M}  1 } } */
+/* { dg-final { scan-assembler-not   {\mlw[az]\M}                } } */
+/* { dg-final { scan-assembler-not   {\mmtvsrw[sz]\M}            } } */

             reply	other threads:[~2023-04-21  4:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21  4:21 Michael Meissner [this message]
2023-04-21 15:35 Michael Meissner
2023-04-21 15:40 Michael Meissner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230421042129.980CE3858D20@sourceware.org \
    --to=meissner@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).