public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-10646] c++: constexpr PMF conversion [PR105996]
@ 2023-04-22 0:23 Jason Merrill
0 siblings, 0 replies; only message in thread
From: Jason Merrill @ 2023-04-22 0:23 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:b6c8048cdd2c1e523f663f248ba39caed5af90e7
commit r11-10646-gb6c8048cdd2c1e523f663f248ba39caed5af90e7
Author: Jason Merrill <jason@redhat.com>
Date: Thu Mar 23 16:50:09 2023 -0400
c++: constexpr PMF conversion [PR105996]
Here, we were calling build_reinterpret_cast regardless of whether there was
actually a cast, and that now sets REINTERPRET_CAST_P. But that
optimization seems dodgy anyway, as it involves NOP_EXPR from one
RECORD_TYPE to another and we try to reserve NOP_EXPR for fundamental types.
And the generated code seems the same, so let's drop it. And also strip
location wrappers.
PR c++/105996
gcc/cp/ChangeLog:
* typeck.c (build_ptrmemfunc): Drop 0-offset optimization
and location wrappers.
gcc/testsuite/ChangeLog:
* g++.dg/cpp0x/constexpr-pmf3.C: New test.
Diff:
---
gcc/cp/typeck.c | 13 +++++--------
gcc/testsuite/g++.dg/cpp0x/constexpr-pmf3.C | 13 +++++++++++++
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c
index c2b703e3cf0..78d679b6c81 100644
--- a/gcc/cp/typeck.c
+++ b/gcc/cp/typeck.c
@@ -9214,18 +9214,15 @@ build_ptrmemfunc (tree type, tree pfn, int force, bool c_cast_p,
if (n == error_mark_node)
return error_mark_node;
+ STRIP_ANY_LOCATION_WRAPPER (pfn);
+
/* We don't have to do any conversion to convert a
pointer-to-member to its own type. But, we don't want to
just return a PTRMEM_CST if there's an explicit cast; that
cast should make the expression an invalid template argument. */
- if (TREE_CODE (pfn) != PTRMEM_CST)
- {
- if (same_type_p (to_type, pfn_type))
- return pfn;
- else if (integer_zerop (n) && TREE_CODE (pfn) != CONSTRUCTOR)
- return build_reinterpret_cast (input_location, to_type, pfn,
- complain);
- }
+ if (TREE_CODE (pfn) != PTRMEM_CST
+ && same_type_p (to_type, pfn_type))
+ return pfn;
if (TREE_SIDE_EFFECTS (pfn))
pfn = save_expr (pfn);
diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-pmf3.C b/gcc/testsuite/g++.dg/cpp0x/constexpr-pmf3.C
new file mode 100644
index 00000000000..14daea312b7
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-pmf3.C
@@ -0,0 +1,13 @@
+// PR c++/105996
+// { dg-do compile { target c++11 } }
+
+struct A {
+ void CB() {}
+};
+struct B : public A { };
+
+using APMF = void (A::*)();
+using BPMF = void (B::*)();
+
+constexpr APMF foo () { return &A::CB; };
+static constexpr BPMF b = foo();
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-22 0:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-22 0:23 [gcc r11-10646] c++: constexpr PMF conversion [PR105996] Jason Merrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).