public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-201] PHIOPT: Allow other diamond uses when do_hoist_loads is true
@ 2023-04-24 15:50 Andrew Pinski
0 siblings, 0 replies; only message in thread
From: Andrew Pinski @ 2023-04-24 15:50 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:7049241f6ee558cfc0b227b5a0a355ec29afd6f1
commit r14-201-g7049241f6ee558cfc0b227b5a0a355ec29afd6f1
Author: Andrew Pinski <apinski@marvell.com>
Date: Thu Apr 20 10:56:17 2023 -0700
PHIOPT: Allow other diamond uses when do_hoist_loads is true
While working on adding diamond shaped form to match-and-simplify
phiopt, I Noticed that we would not reach there if do_hoist_loads
was true. In the original code before the cleanups it was not
obvious why but after I finished the cleanups, it was just a matter
of removing a continue and that is what this patch does.
This just happens also to fix a bug report that I noticed too.
OK? Bootstrapped and tested on x86_64-linux-gnu.
gcc/ChangeLog:
PR tree-optimization/68894
* tree-ssa-phiopt.cc (tree_ssa_phiopt_worker): Remove the
continue for the do_hoist_loads diamond case.
Diff:
---
gcc/tree-ssa-phiopt.cc | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc
index f9d8d6e78b2..ce3409b532b 100644
--- a/gcc/tree-ssa-phiopt.cc
+++ b/gcc/tree-ssa-phiopt.cc
@@ -241,10 +241,7 @@ tree_ssa_phiopt_worker (bool do_store_elim, bool do_hoist_loads, bool early_p)
is likely to perform worse than the well-predicted branch. */
&& !predictable_edge_p (EDGE_SUCC (bb, 0))
&& !predictable_edge_p (EDGE_SUCC (bb, 1)))
- {
- hoist_adjacent_loads (bb, bb1, bb2, bb3);
- continue;
- }
+ hoist_adjacent_loads (bb, bb1, bb2, bb3);
}
gimple_stmt_iterator gsi;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-24 15:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-24 15:50 [gcc r14-201] PHIOPT: Allow other diamond uses when do_hoist_loads is true Andrew Pinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).