public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-216] [Committed] Correct zeroextendqihi2 insn length regression on xstormy16.
@ 2023-04-25 11:05 Roger Sayle
0 siblings, 0 replies; only message in thread
From: Roger Sayle @ 2023-04-25 11:05 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:dee5cef280d6c6da92b56cc0dc2158761c266992
commit r14-216-gdee5cef280d6c6da92b56cc0dc2158761c266992
Author: Roger Sayle <roger@nextmovesoftware.com>
Date: Tue Apr 25 12:04:52 2023 +0100
[Committed] Correct zeroextendqihi2 insn length regression on xstormy16.
My recent tweak to the zeroextendqihi2 pattern on xstormy16 incorrectly
handled the case where the operand was a MEM. MEM operands use a longer
encoding than REG operands, and the incorrect instruction length resulted
in assembler errors (as reported by Jeff Law). This patch restores the
original length resolving this regression. Sorry for the inconvenience.
Committed as obvious, after testing that a cross-compiler to xstormy16-elf
builds from x86_64-pc-linux-gnu, and that gcc.c-torture/execute/memset-2.c
no longer causes "operand out of range" issues in gas. Committed as
obvious.
2023-04-25 Roger Sayle <roger@nextmovesoftware.com>
gcc/ChangeLog
* config/stormy16/stormy16.md (zero_extendqihi2): Restore/fix
length attribute for the first (memory operand) alternative.
Diff:
---
gcc/config/stormy16/stormy16.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/stormy16/stormy16.md b/gcc/config/stormy16/stormy16.md
index fd525881881..9d92492c748 100644
--- a/gcc/config/stormy16/stormy16.md
+++ b/gcc/config/stormy16/stormy16.md
@@ -286,7 +286,7 @@
shl %0,#8 | shr %0,#8"
[(set_attr "psw_operand" "nop,nop,0")
(set_attr_alternative "length"
- [(const_int 2)
+ [(const_int 4)
(const_int 2)
(const_int 4)])])
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-25 11:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-25 11:05 [gcc r14-216] [Committed] Correct zeroextendqihi2 insn length regression on xstormy16 Roger Sayle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).