[gcc r12-9481] tree-optimization/108791 - checking ICE with sloppy ADDR_EXPR

[gcc r12-9481] tree-optimization/108791 - checking ICE with sloppy ADDR_EXPR

[Richard Biener]

https://gcc.gnu.org/g:fcf27816635186acce77dd9b6d756d5c93fd92ef

commit r12-9481-gfcf27816635186acce77dd9b6d756d5c93fd92ef
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Feb 15 14:00:21 2023 +0100

    tree-optimization/108791 - checking ICE with sloppy ADDR_EXPR
    
    The following fixes a checking ICE by choosing a more appropriate
    type for an ADDR_EXPR built by forwprop.
    
            PR tree-optimization/108791
            * tree-ssa-forwprop.cc (optimize_vector_load): Build
            the ADDR_EXPR of a TARGET_MEM_REF using a more meaningful
            type.
    
            * gcc.dg/torture/pr108791.c: New testcase.
    
    (cherry picked from commit 441c466fd4d8b9afd99f585f7c4bfade911c4652)

Diff:
---
 gcc/testsuite/gcc.dg/torture/pr108791.c | 9 +++++++++
 gcc/tree-ssa-forwprop.cc                | 3 ++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/torture/pr108791.c b/gcc/testsuite/gcc.dg/torture/pr108791.c
new file mode 100644
index 00000000000..c1c1cb22aad
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr108791.c
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+
+int f (int *a(), int *b, int *c, int *d)
+{
+  int s = 0;
+  for (int *i = (int *)a; i < b; ++i, ++c)
+    s += *c * d[*i];
+  return s;
+}
diff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc
index 9290d1558e5..062f5667f14 100644
--- a/gcc/tree-ssa-forwprop.cc
+++ b/gcc/tree-ssa-forwprop.cc
@@ -3255,7 +3255,8 @@ optimize_vector_load (gimple_stmt_iterator *gsi)
     {
       if (TREE_CODE (TREE_OPERAND (load_rhs, 0)) == ADDR_EXPR)
 	mark_addressable (TREE_OPERAND (TREE_OPERAND (load_rhs, 0), 0));
-      tree tem = make_ssa_name (TREE_TYPE (TREE_OPERAND (load_rhs, 0)));
+      tree ptrtype = build_pointer_type (TREE_TYPE (load_rhs));
+      tree tem = make_ssa_name (ptrtype);
       gimple *new_stmt
 	= gimple_build_assign (tem, build1 (ADDR_EXPR, TREE_TYPE (tem),
 					    unshare_expr (load_rhs)));