public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-347] Adjust mips test for recent ifcvt costing changes
@ 2023-04-29 16:20 Jeff Law
  0 siblings, 0 replies; only message in thread
From: Jeff Law @ 2023-04-29 16:20 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:ef6c3095aabe75af727a269d91d9ffa37f982ace

commit r14-347-gef6c3095aabe75af727a269d91d9ffa37f982ace
Author: Jeff Law <jlaw@ventanamicro>
Date:   Sat Apr 29 10:16:21 2023 -0600

    Adjust mips test for recent ifcvt costing changes
    
    MIPS ports have been failing a few tests since the change to add cost
    checks in another path through the if-converter pass.
    
    As with the other ports, these look like cases where we don't do good
    costing in the MIPS port.  Someone who cares about MIPS will need to
    fix this properly.
    
    In the mean time this patch adjusts the branch cost when running the
    two affected tests and skips them at -Os.  This is enough to verify
    that if conversion can still happen if the costs are adjusted.
    
    gcc/testsuite
            * gcc.target/mips/mips-ps-type-2.c: Adjust branch cost to
            encourage if-conversion.  Skip for -Os.
            * gcc.target/mips/movcc-3.c: Similarly.

Diff:
---
 gcc/testsuite/gcc.target/mips/mips-ps-type-2.c | 4 ++--
 gcc/testsuite/gcc.target/mips/movcc-3.c        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gcc/testsuite/gcc.target/mips/mips-ps-type-2.c b/gcc/testsuite/gcc.target/mips/mips-ps-type-2.c
index ed5d6ee1663..e5cb7d48dae 100644
--- a/gcc/testsuite/gcc.target/mips/mips-ps-type-2.c
+++ b/gcc/testsuite/gcc.target/mips/mips-ps-type-2.c
@@ -1,8 +1,8 @@
 /* Test v2sf calculations.  The nmadd and nmsub patterns need
    -ffinite-math-only.  */
 /* { dg-do compile } */
-/* { dg-options "(HAS_MADDPS) -mmadd4 -mgp32 -mpaired-single -ffinite-math-only forbid_cpu=octeon.*" } */
-/* { dg-skip-if "nmadd and nmsub need combine" { *-*-* } { "-O0" } { "" } } */
+/* { dg-options "(HAS_MADDPS) -mmadd4 -mgp32 -mpaired-single -ffinite-math-only forbid_cpu=octeon.* -mbranch-cost=2" } */
+/* { dg-skip-if "nmadd and nmsub need combine" { *-*-* } { "-O0" "-Os" } { "" } } */
 /* { dg-final { scan-assembler "\tcvt.ps.s\t" } } */
 /* { dg-final { scan-assembler "\tmov.ps\t" } } */
 /* { dg-final { scan-assembler "\tldc1\t" } } */
diff --git a/gcc/testsuite/gcc.target/mips/movcc-3.c b/gcc/testsuite/gcc.target/mips/movcc-3.c
index 55434b72c72..80d44098a3f 100644
--- a/gcc/testsuite/gcc.target/mips/movcc-3.c
+++ b/gcc/testsuite/gcc.target/mips/movcc-3.c
@@ -1,6 +1,6 @@
 /* { dg-do compile } */
-/* { dg-options "(HAS_MOVN) -mhard-float" } */
-/* { dg-skip-if "code quality test" { *-*-* } { "-O0" } { "" } } */
+/* { dg-options "(HAS_MOVN) -mhard-float -mbranch-cost=2" } */
+/* { dg-skip-if "code quality test" { *-*-* } { "-O0" "-Os" } { "" } } */
 /* { dg-final { scan-assembler "\tmovt\t" } } */
 /* { dg-final { scan-assembler "\tmovf\t" } } */
 /* { dg-final { scan-assembler "\tmovz.s\t" } } */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-04-29 16:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-29 16:20 [gcc r14-347] Adjust mips test for recent ifcvt costing changes Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).