public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/rust/master] libproc_macro: Drop function shall take a mutable
@ 2023-05-02 7:08 Thomas Schwinge
0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2023-05-02 7:08 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:4d1bb3df100323c664875a09ecce830b179d752f
commit 4d1bb3df100323c664875a09ecce830b179d752f
Author: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Date: Fri Apr 7 13:52:04 2023 +0200
libproc_macro: Drop function shall take a mutable
The rust API requires a mut reference, hence having a mutable pointer
seems to match better. Furthermore the implementation is now modifying
the struct in order to set the size to 0 instead of simply freeing the
data, this will allow us to easily identify mistaken manual call to this
function.
ChangeLog:
* libgrust/libproc_macro/rust/bridge/literal.rs: Make the
pointer mutable.
Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Diff:
---
libgrust/libproc_macro/rust/bridge/literal.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libgrust/libproc_macro/rust/bridge/literal.rs b/libgrust/libproc_macro/rust/bridge/literal.rs
index 080cc1b21d8..740ed1fccac 100644
--- a/libgrust/libproc_macro/rust/bridge/literal.rs
+++ b/libgrust/libproc_macro/rust/bridge/literal.rs
@@ -6,7 +6,7 @@ use std::str::FromStr;
use LexError;
extern "C" {
- fn Literal__drop(literal: *const Literal);
+ fn Literal__drop(literal: *mut Literal);
fn Literal__string(str: *const c_uchar, len: u64) -> Literal;
fn Literal__byte_string(bytes: *const u8, len: u64) -> Literal;
fn Literal__from_string(str: *const c_uchar, len: u64, lit: *mut Literal) -> bool;
@@ -230,7 +230,7 @@ impl Drop for Literal {
fn drop(&mut self) {
match self {
Literal::String { .. } | Literal::ByteString { .. } => unsafe {
- Literal__drop(self as *const Literal)
+ Literal__drop(self as *mut Literal)
},
_ => (),
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-05-02 7:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-02 7:08 [gcc/devel/rust/master] libproc_macro: Drop function shall take a mutable Thomas Schwinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).