public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-10708] fortran: Fix up hash table usage in gfc_trans_use_stmts [PR108451]
@ 2023-05-02 20:14 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2023-05-02 20:14 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:658156714de37163d570ace3a868f23900b0efe9
commit r11-10708-g658156714de37163d570ace3a868f23900b0efe9
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Feb 3 21:37:27 2023 +0100
fortran: Fix up hash table usage in gfc_trans_use_stmts [PR108451]
The first testcase in the PR (which I haven't included in the patch because
it is unclear to me if it is supposed to be valid or not) ICEs since extra
hash table checking has been added recently. The problem is that
gfc_trans_use_stmts does
tree *slot = entry->decls->find_slot_with_hash (rent->use_name, hash,
INSERT);
if (*slot == NULL)
and later on doesn't store anything into *slot and continues. Another spot
a few lines later correctly clears the slot if it decides not to use the
slot, so the following patch does the same.
2023-02-03 Jakub Jelinek <jakub@redhat.com>
PR fortran/108451
* trans-decl.c (gfc_trans_use_stmts): Call clear_slot before
doing continue.
(cherry picked from commit 76f7f0eddcb7c418d1ec3dea3e2341ca99097301)
Diff:
---
gcc/fortran/trans-decl.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/gcc/fortran/trans-decl.c b/gcc/fortran/trans-decl.c
index f54b62b4fda..b4fc4afdda3 100644
--- a/gcc/fortran/trans-decl.c
+++ b/gcc/fortran/trans-decl.c
@@ -5431,7 +5431,11 @@ gfc_trans_use_stmts (gfc_namespace * ns)
/* Sometimes, generic interfaces wind up being over-ruled by a
local symbol (see PR41062). */
if (!st->n.sym->attr.use_assoc)
- continue;
+ {
+ *slot = error_mark_node;
+ entry->decls->clear_slot (slot);
+ continue;
+ }
if (st->n.sym->backend_decl
&& DECL_P (st->n.sym->backend_decl)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-05-02 20:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-02 20:14 [gcc r11-10708] fortran: Fix up hash table usage in gfc_trans_use_stmts [PR108451] Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).