public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-10710] match.pd: When simplifying BFR of an insert, require a mode precision integral type [PR108688]
@ 2023-05-02 20:14 Jakub Jelinek
  0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2023-05-02 20:14 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:d87adfe1a6455025eb3ae787a6da245a62cdb446

commit r11-10710-gd87adfe1a6455025eb3ae787a6da245a62cdb446
Author: Andrew Pinski <apinski@marvell.com>
Date:   Thu Feb 9 16:03:54 2023 +0100

    match.pd: When simplifying BFR of an insert, require a mode precision integral type [PR108688]
    
    The same problem as PR 88739 has crept in but
    this time in match.pd when simplifying bit_field_ref of
    an bit_insert. That is we are generating a BIT_FIELD_REF
    of a non-mode-precision integral type.
    
            PR tree-optimization/108688
            * match.pd (bit_field_ref [bit_insert]): Avoid generating
            BIT_FIELD_REFs of non-mode-precision integral operands.
    
            * gcc.c-torture/compile/pr108688-1.c: New test.
    
    (cherry picked from commit 44f308e59bfa0f93ae05b17e257d8563c12399fd)

Diff:
---
 gcc/match.pd                                     |  4 +++-
 gcc/testsuite/gcc.c-torture/compile/pr108688-1.c | 15 +++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/gcc/match.pd b/gcc/match.pd
index 8126f90ee75..91a3762e320 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -6264,7 +6264,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
       isize = tree_to_uhwi (TYPE_SIZE (TREE_TYPE (@1)));
   }
   (switch
-   (if (wi::leu_p (wi::to_wide (@ipos), wi::to_wide (@rpos))
+   (if ((!INTEGRAL_TYPE_P (TREE_TYPE (@1))
+         || type_has_mode_precision_p (TREE_TYPE (@1)))
+        && wi::leu_p (wi::to_wide (@ipos), wi::to_wide (@rpos))
 	&& wi::leu_p (wi::to_wide (@rpos) + wi::to_wide (@rsize),
 		      wi::to_wide (@ipos) + isize))
     (BIT_FIELD_REF @1 @rsize { wide_int_to_tree (bitsizetype,
diff --git a/gcc/testsuite/gcc.c-torture/compile/pr108688-1.c b/gcc/testsuite/gcc.c-torture/compile/pr108688-1.c
new file mode 100644
index 00000000000..43d782d62bd
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/compile/pr108688-1.c
@@ -0,0 +1,15 @@
+
+
+union U { signed int d : 7; signed int e : 2; } u;
+int a, b;
+
+void
+foo (void)
+{
+  for (int i = 0; i < 64; i++)
+    {
+      u.d = a;
+      u.e ^= b;
+    }
+}
+

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-02 20:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-02 20:14 [gcc r11-10710] match.pd: When simplifying BFR of an insert, require a mode precision integral type [PR108688] Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).