public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-411] c++: less invalidate_class_lookup_cache
@ 2023-05-02 20:26 Jason Merrill
  0 siblings, 0 replies; only message in thread
From: Jason Merrill @ 2023-05-02 20:26 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:f9861511a1fa0f9e386f3f7bcee84b6e3ca3c579

commit r14-411-gf9861511a1fa0f9e386f3f7bcee84b6e3ca3c579
Author: Jason Merrill <jason@redhat.com>
Date:   Tue Mar 21 11:12:42 2023 -0400

    c++: less invalidate_class_lookup_cache
    
    In the testcase below, we push_to_top_level to instantiate f and g, and they
    can both use the previous_class_level cache from instantiating A<int>.
    Wiping the cache in pop_from_top_level is not helpful; we'll do that in
    pushclass if needed.
    
      template <class T> struct A
      {
        int i;
        void f() { i = 42; }
        void g() { i = 24; }
      };
    
      int main()
      {
        A<int> a;
        a.f();
        a.g();
      }
    
    gcc/cp/ChangeLog:
    
            * name-lookup.cc (pop_from_top_level): Don't
            invalidate_class_lookup_cache.

Diff:
---
 gcc/cp/name-lookup.cc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gcc/cp/name-lookup.cc b/gcc/cp/name-lookup.cc
index 7c61bc3bf61..8fd5733c1e2 100644
--- a/gcc/cp/name-lookup.cc
+++ b/gcc/cp/name-lookup.cc
@@ -8205,9 +8205,6 @@ pop_from_top_level (void)
 
   auto_cond_timevar tv (TV_NAME_LOOKUP);
 
-  /* Clear out class-level bindings cache.  */
-  if (previous_class_level)
-    invalidate_class_lookup_cache ();
   pop_class_stack ();
 
   release_tree_vector (current_lang_base);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-02 20:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-02 20:26 [gcc r14-411] c++: less invalidate_class_lookup_cache Jason Merrill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).