public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-1540] libgcc: Use initarray section type for .init_stack
@ 2023-06-05  3:40 Kewen Lin
  0 siblings, 0 replies; only message in thread
From: Kewen Lin @ 2023-06-05  3:40 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:83c3550ee96aa2d0c964bfb6d0f82428561479fd

commit r14-1540-g83c3550ee96aa2d0c964bfb6d0f82428561479fd
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Sun Jun 4 22:39:32 2023 -0500

    libgcc: Use initarray section type for .init_stack
    
    One of my workmates found there is a warning like:
    
      libgcc/config/rs6000/morestack.S:402: Warning: ignoring
        incorrect section type for .init_array.00000
    
    when compiling libgcc/config/rs6000/morestack.S.
    
    Since commit r13-6545 touched that file recently, which was
    suspected to be responsible for this warning, I did some
    investigation and found this is a warning staying for a long
    time.  For section .init_stack*, it's preferred to use
    section type SHT_INIT_ARRAY.  So this patch is use
    "@init_array" to replace "@progbits".
    
    Although the warning is trivial, Segher suggested me to
    post this to fix it, in order to avoid any possible
    misunderstanding/confusion on the warning.
    
    As Alan confirmed, this doesn't require a premise check
    on if the existing binutils supports "@init_array" or not,
    "because if you want split-stack to work, you must link
    with gold, any version of binutils that has gold has an
    assembler that understands @init_array". (Thanks Alan!)
    
    libgcc/ChangeLog:
    
            * config/i386/morestack.S: Use @init_array rather than
            @progbits for section type of section .init_array.
            * config/rs6000/morestack.S: Likewise.
            * config/s390/morestack.S: Likewise.

Diff:
---
 libgcc/config/i386/morestack.S   | 2 +-
 libgcc/config/rs6000/morestack.S | 2 +-
 libgcc/config/s390/morestack.S   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/libgcc/config/i386/morestack.S b/libgcc/config/i386/morestack.S
index 7ae99b50cf5..c822b71e2dd 100644
--- a/libgcc/config/i386/morestack.S
+++ b/libgcc/config/i386/morestack.S
@@ -850,7 +850,7 @@ __morestack_make_guard:
 # This is ELF specific.
 
 #if HAVE_INITFINI_ARRAY_SUPPORT
-	.section	.init_array.00000,"aw",@progbits
+	.section	.init_array.00000,"aw",@init_array
 #else
 	.section	.ctors.65535,"aw",@progbits
 #endif
diff --git a/libgcc/config/rs6000/morestack.S b/libgcc/config/rs6000/morestack.S
index f2fea6abb10..dd1e27cd454 100644
--- a/libgcc/config/rs6000/morestack.S
+++ b/libgcc/config/rs6000/morestack.S
@@ -399,7 +399,7 @@ ENTRY0(__morestack_make_guard)
 
 # Make __stack_split_initialize a high priority constructor.
 #if HAVE_INITFINI_ARRAY_SUPPORT
-	.section .init_array.00000,"aw",@progbits
+	.section .init_array.00000,"aw",@init_array
 #else
 	.section .ctors.65535,"aw",@progbits
 #endif
diff --git a/libgcc/config/s390/morestack.S b/libgcc/config/s390/morestack.S
index 09a49bb8851..f52e7a6510c 100644
--- a/libgcc/config/s390/morestack.S
+++ b/libgcc/config/s390/morestack.S
@@ -597,7 +597,7 @@ __morestack_make_guard:
 # Make __stack_split_initialize a high priority constructor.
 
 #if HAVE_INITFINI_ARRAY_SUPPORT
-	.section .init_array.00000,"aw",@progbits
+	.section .init_array.00000,"aw",@init_array
 #else
 	.section .ctors.65535,"aw",@progbits
 #endif

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-05  3:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-05  3:40 [gcc r14-1540] libgcc: Use initarray section type for .init_stack Kewen Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).