public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Florian Weimer <fw@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-1614] libgcc: Fix eh_frame fast path in find_fde_tail
Date: Wed,  7 Jun 2023 15:55:51 +0000 (GMT)	[thread overview]
Message-ID: <20230607155551.91863385C6C7@sourceware.org> (raw)

https://gcc.gnu.org/g:49310a993308492348119f4033e4db0bda4fe46a

commit r14-1614-g49310a993308492348119f4033e4db0bda4fe46a
Author: Florian Weimer <fweimer@redhat.com>
Date:   Tue Jun 6 11:01:07 2023 +0200

    libgcc: Fix eh_frame fast path in find_fde_tail
    
    The eh_frame value is only used by linear_search_fdes, not the binary
    search directly in find_fde_tail, so the bug is not immediately
    apparent with most programs.
    
    Fixes commit e724b0480bfa5ec04f39be8c7290330b495c59de ("libgcc:
    Special-case BFD ld unwind table encodings in find_fde_tail").
    
    libgcc/
    
            PR libgcc/109712
            * unwind-dw2-fde-dip.c (find_fde_tail): Correct fast path for
            parsing eh_frame.

Diff:
---
 libgcc/unwind-dw2-fde-dip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libgcc/unwind-dw2-fde-dip.c b/libgcc/unwind-dw2-fde-dip.c
index 6223f5f18a2..4e0b880513f 100644
--- a/libgcc/unwind-dw2-fde-dip.c
+++ b/libgcc/unwind-dw2-fde-dip.c
@@ -403,8 +403,8 @@ find_fde_tail (_Unwind_Ptr pc,
 	 BFD ld generates.  */
       signed value __attribute__ ((mode (SI)));
       memcpy (&value, p, sizeof (value));
+      eh_frame = p + value;
       p += sizeof (value);
-      dbase = value;		/* No adjustment because pcrel has base 0.  */
     }
   else
     p = read_encoded_value_with_base (hdr->eh_frame_ptr_enc,

                 reply	other threads:[~2023-06-07 15:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230607155551.91863385C6C7@sourceware.org \
    --to=fw@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).