public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-1614] libgcc: Fix eh_frame fast path in find_fde_tail
@ 2023-06-07 15:55 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2023-06-07 15:55 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:49310a993308492348119f4033e4db0bda4fe46a

commit r14-1614-g49310a993308492348119f4033e4db0bda4fe46a
Author: Florian Weimer <fweimer@redhat.com>
Date:   Tue Jun 6 11:01:07 2023 +0200

    libgcc: Fix eh_frame fast path in find_fde_tail
    
    The eh_frame value is only used by linear_search_fdes, not the binary
    search directly in find_fde_tail, so the bug is not immediately
    apparent with most programs.
    
    Fixes commit e724b0480bfa5ec04f39be8c7290330b495c59de ("libgcc:
    Special-case BFD ld unwind table encodings in find_fde_tail").
    
    libgcc/
    
            PR libgcc/109712
            * unwind-dw2-fde-dip.c (find_fde_tail): Correct fast path for
            parsing eh_frame.

Diff:
---
 libgcc/unwind-dw2-fde-dip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libgcc/unwind-dw2-fde-dip.c b/libgcc/unwind-dw2-fde-dip.c
index 6223f5f18a2..4e0b880513f 100644
--- a/libgcc/unwind-dw2-fde-dip.c
+++ b/libgcc/unwind-dw2-fde-dip.c
@@ -403,8 +403,8 @@ find_fde_tail (_Unwind_Ptr pc,
 	 BFD ld generates.  */
       signed value __attribute__ ((mode (SI)));
       memcpy (&value, p, sizeof (value));
+      eh_frame = p + value;
       p += sizeof (value);
-      dbase = value;		/* No adjustment because pcrel has base 0.  */
     }
   else
     p = read_encoded_value_with_base (hdr->eh_frame_ptr_enc,

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-07 15:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-07 15:55 [gcc r14-1614] libgcc: Fix eh_frame fast path in find_fde_tail Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).