public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-1655] Change the `(zero_one ==/!= 0) ? y : z <op> y` patterns to use multiply rather than `(-zero_one) & z Date: Fri, 9 Jun 2023 14:16:07 +0000 (GMT) [thread overview] Message-ID: <20230609141607.5A1A4385662B@sourceware.org> (raw) https://gcc.gnu.org/g:52c92fb3f4005051e86bb3e9c70a13fb34954cd1 commit r14-1655-g52c92fb3f4005051e86bb3e9c70a13fb34954cd1 Author: Andrew Pinski <apinski@marvell.com> Date: Wed Jun 7 07:43:50 2023 -0700 Change the `(zero_one ==/!= 0) ? y : z <op> y` patterns to use multiply rather than `(-zero_one) & z` Since there is a pattern to convert `(-zero_one) & z` into `zero_one * z` already, it is better if we don't do a secondary transformation. This reduces the extra statements produced by match-and-simplify on the gimple level too. gcc/ChangeLog: * match.pd ((zero_one ==/!= 0) ? y : z <op> y): Use multiply rather than negation/bit_and. Diff: --- gcc/match.pd | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/match.pd b/gcc/match.pd index 77030b3b50b..610668d562c 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -3695,7 +3695,7 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (cond (le @0 integer_zerop@1) (negate@2 @0) integer_zerop@1) (max @2 @1)) -/* (zero_one == 0) ? y : z <op> y -> (-(typeof(y))zero_one & z) <op> y */ +/* (zero_one == 0) ? y : z <op> y -> ((typeof(y))zero_one * z) <op> y */ (for op (bit_xor bit_ior) (simplify (cond (eq zero_one_valued_p@0 @@ -3705,9 +3705,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (if (INTEGRAL_TYPE_P (type) && TYPE_PRECISION (type) > 1 && (INTEGRAL_TYPE_P (TREE_TYPE (@0)))) - (op (bit_and (negate (convert:type @0)) @2) @1)))) + (op (mult (convert:type @0) @2) @1)))) -/* (zero_one != 0) ? z <op> y : y -> (-(typeof(y))zero_one & z) <op> y */ +/* (zero_one != 0) ? z <op> y : y -> ((typeof(y))zero_one * z) <op> y */ (for op (bit_xor bit_ior) (simplify (cond (ne zero_one_valued_p@0 @@ -3717,7 +3717,7 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (if (INTEGRAL_TYPE_P (type) && TYPE_PRECISION (type) > 1 && (INTEGRAL_TYPE_P (TREE_TYPE (@0)))) - (op (bit_and (negate (convert:type @0)) @2) @1)))) + (op (mult (convert:type @0) @2) @1)))) /* Simplifications of shift and rotates. */
reply other threads:[~2023-06-09 14:16 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230609141607.5A1A4385662B@sourceware.org \ --to=pinskia@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).