public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-1655] Change the `(zero_one ==/!= 0) ? y : z <op> y` patterns to use multiply rather than `(-zero_one) & z
@ 2023-06-09 14:16 Andrew Pinski
0 siblings, 0 replies; only message in thread
From: Andrew Pinski @ 2023-06-09 14:16 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:52c92fb3f4005051e86bb3e9c70a13fb34954cd1
commit r14-1655-g52c92fb3f4005051e86bb3e9c70a13fb34954cd1
Author: Andrew Pinski <apinski@marvell.com>
Date: Wed Jun 7 07:43:50 2023 -0700
Change the `(zero_one ==/!= 0) ? y : z <op> y` patterns to use multiply rather than `(-zero_one) & z`
Since there is a pattern to convert `(-zero_one) & z` into `zero_one * z` already,
it is better if we don't do a secondary transformation. This reduces the extra
statements produced by match-and-simplify on the gimple level too.
gcc/ChangeLog:
* match.pd ((zero_one ==/!= 0) ? y : z <op> y): Use
multiply rather than negation/bit_and.
Diff:
---
gcc/match.pd | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gcc/match.pd b/gcc/match.pd
index 77030b3b50b..610668d562c 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -3695,7 +3695,7 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
(cond (le @0 integer_zerop@1) (negate@2 @0) integer_zerop@1)
(max @2 @1))
-/* (zero_one == 0) ? y : z <op> y -> (-(typeof(y))zero_one & z) <op> y */
+/* (zero_one == 0) ? y : z <op> y -> ((typeof(y))zero_one * z) <op> y */
(for op (bit_xor bit_ior)
(simplify
(cond (eq zero_one_valued_p@0
@@ -3705,9 +3705,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
(if (INTEGRAL_TYPE_P (type)
&& TYPE_PRECISION (type) > 1
&& (INTEGRAL_TYPE_P (TREE_TYPE (@0))))
- (op (bit_and (negate (convert:type @0)) @2) @1))))
+ (op (mult (convert:type @0) @2) @1))))
-/* (zero_one != 0) ? z <op> y : y -> (-(typeof(y))zero_one & z) <op> y */
+/* (zero_one != 0) ? z <op> y : y -> ((typeof(y))zero_one * z) <op> y */
(for op (bit_xor bit_ior)
(simplify
(cond (ne zero_one_valued_p@0
@@ -3717,7 +3717,7 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
(if (INTEGRAL_TYPE_P (type)
&& TYPE_PRECISION (type) > 1
&& (INTEGRAL_TYPE_P (TREE_TYPE (@0))))
- (op (bit_and (negate (convert:type @0)) @2) @1))))
+ (op (mult (convert:type @0) @2) @1))))
/* Simplifications of shift and rotates. */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-09 14:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-09 14:16 [gcc r14-1655] Change the `(zero_one ==/!= 0) ? y : z <op> y` patterns to use multiply rather than `(-zero_one) & z Andrew Pinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).