[gcc r14-1749] ada: Tune style in detection of writable function actuals

[gcc r14-1749] ada: Tune style in detection of writable function actuals

[Marc Poulhi?s]

https://gcc.gnu.org/g:fbf4140df117d28428e03a3f3c986787609d32b6

commit r14-1749-gfbf4140df117d28428e03a3f3c986787609d32b6
Author: Piotr Trojanek <trojanek@adacore.com>
Date:   Mon Mar 20 20:27:09 2023 +0100

    ada: Tune style in detection of writable function actuals
    
    Cleanup; semantics is unaffected.
    
    gcc/ada/
    
            * sem_util.adb (Check_Function_Writable_Actuals): Tune style; use
            subtype name to detect membership test nodes.

Diff:
---
 gcc/ada/sem_util.adb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb
index a75ebf5d7b1..237bbd3987c 100644
--- a/gcc/ada/sem_util.adb
+++ b/gcc/ada/sem_util.adb
@@ -2899,6 +2899,10 @@ package body Sem_Util is
                function Get_Record_Part (N : Node_Id) return Node_Id;
                --  Return the record part of this record type definition
 
+               ---------------------
+               -- Get_Record_Part --
+               ---------------------
+
                function Get_Record_Part (N : Node_Id) return Node_Id is
                   Type_Def : constant Node_Id := Type_Definition (N);
                begin
@@ -3293,9 +3297,7 @@ package body Sem_Util is
                               & "in unspecified order",
                               Node (Elmt_2));
 
-                        when N_In
-                           | N_Not_In
-                        =>
+                        when N_Membership_Test =>
                            Error_Msg_N
                              ("value may be affected by call in other "
                               & "alternative because they are evaluated "
@@ -3307,7 +3309,7 @@ package body Sem_Util is
                              ("value of actual may be affected by call in "
                               & "other actual because they are evaluated "
                               & "in unspecified order",
-                           Node (Elmt_2));
+                              Node (Elmt_2));
                      end case;
                   end if;