public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-1858] ada: Revert latest change to Find_Hook_Context
@ 2023-06-15  8:03 Marc Poulhi?s
  0 siblings, 0 replies; only message in thread
From: Marc Poulhi?s @ 2023-06-15  8:03 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:9cdaa52bf8e0529c3d4d13121c440f92113ff05d

commit r14-1858-g9cdaa52bf8e0529c3d4d13121c440f92113ff05d
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Tue May 16 11:35:23 2023 +0200

    ada: Revert latest change to Find_Hook_Context
    
    The issue is that, if an aggregate is both below a conditional expression
    and above another conditional expression in the tree, we have currently no
    place to put the finalization actions generated by the innermost expression
    in the context of the aggregate before it is expanded, so they end up being
    placed after the outermost expression.
    
    But it is not clear whether that's really problematic because this does not
    seem to happen for array aggregates with multiple or others choices: in this
    case the aggregate is expanded first and the code path is not taken.
    
    gcc/ada/
    
            * exp_util.adb (Find_Hook_Context): Revert latest change.

Diff:
---
 gcc/ada/exp_util.adb | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/gcc/ada/exp_util.adb b/gcc/ada/exp_util.adb
index a4aa5f64447..91959793638 100644
--- a/gcc/ada/exp_util.adb
+++ b/gcc/ada/exp_util.adb
@@ -6500,16 +6500,6 @@ package body Exp_Util is
             then
                Top := Par;
 
-            --  Stop at contexts where temporaries may be contained
-
-            elsif Nkind (Par) in N_Aggregate
-                               | N_Delta_Aggregate
-                               | N_Extension_Aggregate
-                               | N_Block_Statement
-                               | N_Loop_Statement
-            then
-               exit;
-
             --  Prevent the search from going too far
 
             elsif Is_Body_Or_Package_Declaration (Par) then

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-15  8:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-15  8:03 [gcc r14-1858] ada: Revert latest change to Find_Hook_Context Marc Poulhi?s

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).