public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-1876] c: add name hints to c_parser_declspecs [PR107583]
@ 2023-06-16 0:59 David Malcolm
0 siblings, 0 replies; only message in thread
From: David Malcolm @ 2023-06-16 0:59 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:57446d1bc9757ee1fb030600d38fa9487231f2a4
commit r14-1876-g57446d1bc9757ee1fb030600d38fa9487231f2a4
Author: David Malcolm <dmalcolm@redhat.com>
Date: Thu Jun 15 20:56:41 2023 -0400
c: add name hints to c_parser_declspecs [PR107583]
PR c/107583 notes that we weren't issuing a hint for
struct foo {
time_t mytime; /* missing <time.h> include should trigger fixit */
};
in the C frontend.
The root cause is that one of the "unknown type name" diagnostics
was missing logic to emit hints, which this patch fixes.
gcc/c/ChangeLog:
PR c/107583
* c-parser.cc (c_parser_declspecs): Add hints to "unknown type
name" error.
gcc/testsuite/ChangeLog:
PR c/107583
* c-c++-common/spellcheck-pr107583.c: New test.
Signed-off-by: David Malcolm <dmalcolm@redhat.com>
Diff:
---
gcc/c/c-parser.cc | 14 +++++++++++++-
gcc/testsuite/c-c++-common/spellcheck-pr107583.c | 10 ++++++++++
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/gcc/c/c-parser.cc b/gcc/c/c-parser.cc
index 61487cc7481..24a6eb6e459 100644
--- a/gcc/c/c-parser.cc
+++ b/gcc/c/c-parser.cc
@@ -3182,7 +3182,19 @@ c_parser_declspecs (c_parser *parser, struct c_declspecs *specs,
attrs_ok = true;
if (kind == C_ID_ID)
{
- error_at (loc, "unknown type name %qE", value);
+ auto_diagnostic_group d;
+ name_hint hint = lookup_name_fuzzy (value, FUZZY_LOOKUP_TYPENAME,
+ loc);
+ if (const char *suggestion = hint.suggestion ())
+ {
+ gcc_rich_location richloc (loc);
+ richloc.add_fixit_replace (suggestion);
+ error_at (&richloc,
+ "unknown type name %qE; did you mean %qs?",
+ value, suggestion);
+ }
+ else
+ error_at (loc, "unknown type name %qE", value);
t.kind = ctsk_typedef;
t.spec = error_mark_node;
}
diff --git a/gcc/testsuite/c-c++-common/spellcheck-pr107583.c b/gcc/testsuite/c-c++-common/spellcheck-pr107583.c
new file mode 100644
index 00000000000..86a9e7dbcb6
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/spellcheck-pr107583.c
@@ -0,0 +1,10 @@
+struct s1 {
+ time_t mytime; /* { dg-error "unknown type name 'time_t'" "c error" { target c } } */
+ /* { dg-error "'time_t' does not name a type" "c++ error" { target c++ } .-1 } */
+ /* { dg-message "'time_t' is defined in header" "hint" { target *-*-* } .-2 } */
+};
+
+struct s2 {
+ unsinged i; /* { dg-error "unknown type name 'unsinged'; did you mean 'unsigned'." "c error" { target c } } */
+ /* { dg-error "'unsinged' does not name a type; did you mean 'unsigned'." "c++ error" { target c++ } .-1 } */
+};
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-16 0:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-16 0:59 [gcc r14-1876] c: add name hints to c_parser_declspecs [PR107583] David Malcolm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).