public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-1967] ada: Fix -fdiagnostics-format=json not printing all messages
@ 2023-06-20 7:46 Marc Poulhi?s
0 siblings, 0 replies; only message in thread
From: Marc Poulhi?s @ 2023-06-20 7:46 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:3404e481d09d49311ef74a8de15d8a72ed240cce
commit r14-1967-g3404e481d09d49311ef74a8de15d8a72ed240cce
Author: Ghjuvan Lacambre <lacambre@adacore.com>
Date: Fri May 26 13:26:21 2023 +0200
ada: Fix -fdiagnostics-format=json not printing all messages
The previous version of this code stopped printing messages as soon as
it encountered a deleted or continuation message. This was wrong,
continuation and deleted messages can be followed by live messages that
do need to be printed.
gcc/ada/
* errout.adb (Output_Messages): Fix loop termination condition.
Diff:
---
gcc/ada/errout.adb | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/gcc/ada/errout.adb b/gcc/ada/errout.adb
index 1c6222b3a29..6e378a60731 100644
--- a/gcc/ada/errout.adb
+++ b/gcc/ada/errout.adb
@@ -3062,16 +3062,19 @@ package body Errout is
E := Errors.Table (E).Next;
- -- Skip deleted messages.
- -- Also skip continuation messages, as they have already been
- -- printed along the message they're attached to.
+ while E /= No_Error_Msg loop
+
+ -- Skip deleted messages.
+ -- Also skip continuation messages, as they have already been
+ -- printed along the message they're attached to.
+
+ if not Errors.Table (E).Deleted
+ and then not Errors.Table (E).Msg_Cont
+ then
+ Write_Char (',');
+ Output_JSON_Message (E);
+ end if;
- while E /= No_Error_Msg
- and then not Errors.Table (E).Deleted
- and then not Errors.Table (E).Msg_Cont
- loop
- Write_Char (',');
- Output_JSON_Message (E);
E := Errors.Table (E).Next;
end loop;
end if;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-20 7:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-20 7:46 [gcc r14-1967] ada: Fix -fdiagnostics-format=json not printing all messages Marc Poulhi?s
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).