public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-2042] Properly guard vect_look_through_possible_promotion
@ 2023-06-23 9:23 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2023-06-23 9:23 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:4127e0f3313c961b4b4e5efad85a25c40c2510c2
commit r14-2042-g4127e0f3313c961b4b4e5efad85a25c40c2510c2
Author: Richard Biener <rguenther@suse.de>
Date: Fri Jun 23 10:08:50 2023 +0200
Properly guard vect_look_through_possible_promotion
The function ends up getting called on VECTOR_TYPEs which it
really isn't prepared for and with the TYPE_PRECISION checking
changes will ICE. The following exits early when the type
to work on isn't scalar integral.
* tree-vect-patterns.cc (vect_look_through_possible_promotion):
Exit early when the type isn't scalar integral.
Diff:
---
gcc/tree-vect-patterns.cc | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc
index 60bc9be6819..a04accf3b03 100644
--- a/gcc/tree-vect-patterns.cc
+++ b/gcc/tree-vect-patterns.cc
@@ -398,8 +398,11 @@ vect_look_through_possible_promotion (vec_info *vinfo, tree op,
vect_unpromoted_value *unprom,
bool *single_use_p = NULL)
{
- tree res = NULL_TREE;
tree op_type = TREE_TYPE (op);
+ if (!INTEGRAL_TYPE_P (op_type))
+ return NULL_TREE;
+
+ tree res = NULL_TREE;
unsigned int orig_precision = TYPE_PRECISION (op_type);
unsigned int min_precision = orig_precision;
stmt_vec_info caster = NULL;
@@ -3881,6 +3884,7 @@ vect_recog_vector_vector_shift_pattern (vec_info *vinfo,
if (TREE_CODE (oprnd0) != SSA_NAME
|| TREE_CODE (oprnd1) != SSA_NAME
|| TYPE_MODE (TREE_TYPE (oprnd0)) == TYPE_MODE (TREE_TYPE (oprnd1))
+ || !INTEGRAL_TYPE_P (TREE_TYPE (oprnd0))
|| !type_has_mode_precision_p (TREE_TYPE (oprnd1))
|| TYPE_PRECISION (TREE_TYPE (lhs))
!= TYPE_PRECISION (TREE_TYPE (oprnd0)))
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-23 9:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-23 9:23 [gcc r14-2042] Properly guard vect_look_through_possible_promotion Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).