public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: fix expand function of vlmul_ext RVV intrinsic
@ 2023-06-26 20:57 Jeff Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2023-06-26 20:57 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:5b8f16c4639a3da75c26cdd0bfeea0dea2dd8d6b

commit 5b8f16c4639a3da75c26cdd0bfeea0dea2dd8d6b
Author: Li Xu <xuli1@eswincomputing.com>
Date:   Sun Jun 25 09:09:32 2023 +0000

    RISC-V: fix expand function of vlmul_ext RVV intrinsic
    
    Consider this following case:
    void test_vlmul_ext_v_i8mf8_i8mf4(vint8mf8_t op1) {
      vint8mf4_t res = __riscv_vlmul_ext_v_i8mf8_i8mf4(op1);
    }
    
    Compilation fails with:
    test.c: In function 'test_vlmul_ext_v_i8mf8_i8mf4':
    test.c:5:1: error: unrecognizable insn:
        5 | }
          | ^
    (insn 30 29 0 2 (set (mem/c:VNx2QI (reg/f:DI 143) [0 x+0 S[2, 2] A32])
            (mem/c:VNx2QI (reg/f:DI 148) [0 op1+0 S[2, 2] A16])) "test.c":4:18 -1
         (nil))
    during RTL pass: vregs
    test.c:5:1: internal compiler error: in extract_insn, at recog.cc:2791
    0x7c61b8 _fatal_insn(char const*, rtx_def const*, char const*, int, char const*)
            ../.././riscv-gcc/gcc/rtl-error.cc:108
    0x7c61d7 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
            ../.././riscv-gcc/gcc/rtl-error.cc:116
    0xed58a7 extract_insn(rtx_insn*)
            ../.././riscv-gcc/gcc/recog.cc:2791
    0xb7f789 instantiate_virtual_regs_in_insn
            ../.././riscv-gcc/gcc/function.cc:1611
    0xb7f789 instantiate_virtual_regs
            ../.././riscv-gcc/gcc/function.cc:1984
    
    gcc/ChangeLog:
    
            * config/riscv/riscv-vector-builtins-bases.cc: change emit_insn to
            emit_move_insn
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/riscv/rvv/base/vlmul_ext-2.c: New test.

Diff:
---
 gcc/config/riscv/riscv-vector-builtins-bases.cc       | 2 +-
 gcc/testsuite/gcc.target/riscv/rvv/base/vlmul_ext-2.c | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
index c6c53dc13a5..5c8deda900d 100644
--- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
+++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
@@ -1567,7 +1567,7 @@ public:
   {
     tree arg = CALL_EXPR_ARG (e.exp, 0);
     rtx src = expand_normal (arg);
-    emit_insn (gen_rtx_SET (gen_lowpart (e.vector_mode (), e.target), src));
+    emit_move_insn (gen_lowpart (e.vector_mode (), e.target), src);
     return e.target;
   }
 };
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/vlmul_ext-2.c b/gcc/testsuite/gcc.target/riscv/rvv/base/vlmul_ext-2.c
new file mode 100644
index 00000000000..2b088b53546
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/rvv/base/vlmul_ext-2.c
@@ -0,0 +1,8 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gcv -mabi=lp64d -O0" } */
+
+#include "riscv_vector.h"
+
+void test_vlmul_ext_v_i8mf8_i8mf4(vint8mf8_t op1) {
+  vint8mf4_t res = __riscv_vlmul_ext_v_i8mf8_i8mf4(op1);
+}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: fix expand function of vlmul_ext RVV intrinsic
@ 2023-07-14  2:49 Jeff Law
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2023-07-14  2:49 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:085a49648786a7d48121a2b2cfc98d8e166dec46

commit 085a49648786a7d48121a2b2cfc98d8e166dec46
Author: Li Xu <xuli1@eswincomputing.com>
Date:   Sun Jun 25 09:09:32 2023 +0000

    RISC-V: fix expand function of vlmul_ext RVV intrinsic
    
    Consider this following case:
    void test_vlmul_ext_v_i8mf8_i8mf4(vint8mf8_t op1) {
      vint8mf4_t res = __riscv_vlmul_ext_v_i8mf8_i8mf4(op1);
    }
    
    Compilation fails with:
    test.c: In function 'test_vlmul_ext_v_i8mf8_i8mf4':
    test.c:5:1: error: unrecognizable insn:
        5 | }
          | ^
    (insn 30 29 0 2 (set (mem/c:VNx2QI (reg/f:DI 143) [0 x+0 S[2, 2] A32])
            (mem/c:VNx2QI (reg/f:DI 148) [0 op1+0 S[2, 2] A16])) "test.c":4:18 -1
         (nil))
    during RTL pass: vregs
    test.c:5:1: internal compiler error: in extract_insn, at recog.cc:2791
    0x7c61b8 _fatal_insn(char const*, rtx_def const*, char const*, int, char const*)
            ../.././riscv-gcc/gcc/rtl-error.cc:108
    0x7c61d7 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
            ../.././riscv-gcc/gcc/rtl-error.cc:116
    0xed58a7 extract_insn(rtx_insn*)
            ../.././riscv-gcc/gcc/recog.cc:2791
    0xb7f789 instantiate_virtual_regs_in_insn
            ../.././riscv-gcc/gcc/function.cc:1611
    0xb7f789 instantiate_virtual_regs
            ../.././riscv-gcc/gcc/function.cc:1984
    
    gcc/ChangeLog:
    
            * config/riscv/riscv-vector-builtins-bases.cc: change emit_insn to
            emit_move_insn
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/riscv/rvv/base/vlmul_ext-2.c: New test.

Diff:
---
 gcc/config/riscv/riscv-vector-builtins-bases.cc       | 2 +-
 gcc/testsuite/gcc.target/riscv/rvv/base/vlmul_ext-2.c | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
index c6c53dc13a5..5c8deda900d 100644
--- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
+++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
@@ -1567,7 +1567,7 @@ public:
   {
     tree arg = CALL_EXPR_ARG (e.exp, 0);
     rtx src = expand_normal (arg);
-    emit_insn (gen_rtx_SET (gen_lowpart (e.vector_mode (), e.target), src));
+    emit_move_insn (gen_lowpart (e.vector_mode (), e.target), src);
     return e.target;
   }
 };
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/vlmul_ext-2.c b/gcc/testsuite/gcc.target/riscv/rvv/base/vlmul_ext-2.c
new file mode 100644
index 00000000000..2b088b53546
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/rvv/base/vlmul_ext-2.c
@@ -0,0 +1,8 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gcv -mabi=lp64d -O0" } */
+
+#include "riscv_vector.h"
+
+void test_vlmul_ext_v_i8mf8_i8mf4(vint8mf8_t op1) {
+  vint8mf4_t res = __riscv_vlmul_ext_v_i8mf8_i8mf4(op1);
+}

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-14  2:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-26 20:57 [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: fix expand function of vlmul_ext RVV intrinsic Jeff Law
2023-07-14  2:49 Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).