public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-2255] tree-optimization/110506 - bogus non-zero mask in CCP for vector types
@ 2023-07-03  8:05 Richard Biener
  0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2023-07-03  8:05 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:bd7e9856fe5bbeb487797476c4fffb660f63cf4f

commit r14-2255-gbd7e9856fe5bbeb487797476c4fffb660f63cf4f
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Jul 3 08:28:17 2023 +0200

    tree-optimization/110506 - bogus non-zero mask in CCP for vector types
    
    get_value_for_expr was blindlessly using TYPE_PRECISION to produce
    a mask for vector typed entities which the new tree checking now
    catches.
    
            PR tree-optimization/110506
            * tree-ssa-ccp.cc (get_value_for_expr): Check for integral
            type before relying on TYPE_PRECISION to produce a nonzero mask.
    
            * gcc.dg/pr110506.c: New testcase.

Diff:
---
 gcc/testsuite/gcc.dg/pr110506.c | 24 ++++++++++++++++++++++++
 gcc/tree-ssa-ccp.cc             |  1 +
 2 files changed, 25 insertions(+)

diff --git a/gcc/testsuite/gcc.dg/pr110506.c b/gcc/testsuite/gcc.dg/pr110506.c
new file mode 100644
index 00000000000..10dbd4e6ce6
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr110506.c
@@ -0,0 +1,24 @@
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+
+struct {
+  long *sp;
+  long *csp;
+} neko_interp_loop_vm;
+int neko_interp_loop_vm_2;
+void neko_interp_loop()
+{
+  void *pc[] = {&&LabelAccGlobal, &&LabelPhysCompare, &&LabelTailCall,
+      &&LabelLoop, &&LabelMakeArray2};
+  long *sp, *csp = neko_interp_loop_vm.csp;
+LabelAccGlobal:
+  neko_interp_loop_vm.sp = sp;
+  neko_interp_loop_vm.csp = csp;
+  goto * 0;
+LabelTailCall:
+  csp = sp -= neko_interp_loop_vm_2;
+LabelMakeArray2:
+LabelPhysCompare:
+LabelLoop:
+  goto * 0;
+}
diff --git a/gcc/tree-ssa-ccp.cc b/gcc/tree-ssa-ccp.cc
index 26d5e445abd..0d0f02a8442 100644
--- a/gcc/tree-ssa-ccp.cc
+++ b/gcc/tree-ssa-ccp.cc
@@ -682,6 +682,7 @@ get_value_for_expr (tree expr, bool for_bits_p)
     }
 
   if (val.lattice_val == VARYING
+      && INTEGRAL_TYPE_P (TREE_TYPE (expr))
       && TYPE_UNSIGNED (TREE_TYPE (expr)))
     val.mask = wi::zext (val.mask, TYPE_PRECISION (TREE_TYPE (expr)));

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-07-03  8:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03  8:05 [gcc r14-2255] tree-optimization/110506 - bogus non-zero mask in CCP for vector types Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).