public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-4293] remove workaround for GCC 4.1-4.3 [PR105606]
@ 2023-09-27 8:39 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2023-09-27 8:39 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:3ba882c7b51ab1f14c62c748e989415834ccd9ce
commit r14-4293-g3ba882c7b51ab1f14c62c748e989415834ccd9ce
Author: Jakub Jelinek <jakub@redhat.com>
Date: Wed Sep 27 10:38:54 2023 +0200
remove workaround for GCC 4.1-4.3 [PR105606]
While looking into vec.h, I've noticed we still have a workaround for
GCC 4.1-4.3 bugs.
As we now use C++11 and thus need to be built by GCC 4.8 or later,
I think this is now never used.
2023-09-27 Jakub Jelinek <jakub@redhat.com>
PR c++/105606
* system.h (BROKEN_VALUE_INITIALIZATION): Don't define.
* vec.h (vec_default_construct): Remove BROKEN_VALUE_INITIALIZATION
workaround.
* function.cc (assign_parm_find_data_types): Likewise.
Diff:
---
gcc/function.cc | 8 --------
gcc/system.h | 6 ------
gcc/vec.h | 15 ---------------
3 files changed, 29 deletions(-)
diff --git a/gcc/function.cc b/gcc/function.cc
index dd2c1136e07..e92384a8907 100644
--- a/gcc/function.cc
+++ b/gcc/function.cc
@@ -2429,15 +2429,7 @@ assign_parm_find_data_types (struct assign_parm_data_all *all, tree parm,
{
int unsignedp;
-#ifndef BROKEN_VALUE_INITIALIZATION
*data = assign_parm_data_one ();
-#else
- /* Old versions of GCC used to miscompile the above by only initializing
- the members with explicit constructors and copying garbage
- to the other members. */
- assign_parm_data_one zero_data = {};
- *data = zero_data;
-#endif
/* NAMED_ARG is a misnomer. We really mean 'non-variadic'. */
if (!cfun->stdarg)
diff --git a/gcc/system.h b/gcc/system.h
index 5109c60c600..e924152ad4c 100644
--- a/gcc/system.h
+++ b/gcc/system.h
@@ -905,12 +905,6 @@ extern void fancy_abort (const char *, int, const char *)
/* Some compilers do not allow the use of unsigned char in bitfields. */
#define BOOL_BITFIELD unsigned int
-/* GCC older than 4.4 have broken C++ value initialization handling, see
- PR11309, PR30111, PR33916, PR82939 and PR84405 for more details. */
-#if GCC_VERSION > 0 && GCC_VERSION < 4004 && !defined(__clang__)
-# define BROKEN_VALUE_INITIALIZATION
-#endif
-
/* As the last action in this file, we poison the identifiers that
shouldn't be used. Note, luckily gcc-3.0's token-based integrated
preprocessor won't trip on poisoned identifiers that arrive from
diff --git a/gcc/vec.h b/gcc/vec.h
index 6f7b0487eb6..8a9a8d83de5 100644
--- a/gcc/vec.h
+++ b/gcc/vec.h
@@ -512,21 +512,6 @@ template <typename T>
inline void
vec_default_construct (T *dst, unsigned n)
{
-#ifdef BROKEN_VALUE_INITIALIZATION
- /* Versions of GCC before 4.4 sometimes leave certain objects
- uninitialized when value initialized, though if the type has
- user defined default ctor, that ctor is invoked. As a workaround
- perform clearing first and then the value initialization, which
- fixes the case when value initialization doesn't initialize due to
- the bugs and should initialize to all zeros, but still allows
- vectors for types with user defined default ctor that initializes
- some or all elements to non-zero. If T has no user defined
- default ctor and some non-static data members have user defined
- default ctors that initialize to non-zero the workaround will
- still not work properly; in that case we just need to provide
- user defined default ctor. */
- memset (dst, '\0', sizeof (T) * n);
-#endif
for ( ; n; ++dst, --n)
::new (static_cast<void*>(dst)) T ();
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-09-27 8:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-27 8:39 [gcc r14-4293] remove workaround for GCC 4.1-4.3 [PR105606] Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).