public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-4674] LoongArch: Delete macro definition ASM_OUTPUT_ALIGN_WITH_NOP.
@ 2023-10-17  2:08 LuluCheng
  0 siblings, 0 replies; only message in thread
From: LuluCheng @ 2023-10-17  2:08 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:b20c7ee066cb7d952fa193972e8bc6362c6e4063

commit r14-4674-gb20c7ee066cb7d952fa193972e8bc6362c6e4063
Author: Lulu Cheng <chenglulu@loongson.cn>
Date:   Fri Sep 15 11:56:01 2023 +0800

    LoongArch: Delete macro definition ASM_OUTPUT_ALIGN_WITH_NOP.
    
    There are two reasons for removing this macro definition:
    1. The default in the assembler is to use the nop instruction for filling.
    2. For assembly directives: .align [abs-expr[, abs-expr[, abs-expr]]]
       The third expression it is the maximum number of bytes that should be
       skipped by this alignment directive.
       Therefore, it will affect the display of the specified alignment rules
       and affect the operating efficiency.
    
    This modification relies on binutils commit 1fb3cdd87ec61715a5684925fb6d6a6cf53bb97c.
    (Since the assembler will add nop based on the .align information when doing relax,
    it will cause the conditional branch to go out of bounds during the assembly process.
    This submission of binutils solves this problem.)
    
    gcc/ChangeLog:
    
            * config/loongarch/loongarch.h (ASM_OUTPUT_ALIGN_WITH_NOP):
            Delete.
    
    Co-authored-by: Chenghua Xu <xuchenghua@loongson.cn>

Diff:
---
 gcc/config/loongarch/loongarch.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loongarch.h
index 19a18fb5f1b4..da3ec2add9ad 100644
--- a/gcc/config/loongarch/loongarch.h
+++ b/gcc/config/loongarch/loongarch.h
@@ -1058,11 +1058,6 @@ typedef struct {
 
 #define ASM_OUTPUT_ALIGN(STREAM, LOG) fprintf (STREAM, "\t.align\t%d\n", (LOG))
 
-/* "nop" instruction 54525952 (andi $r0,$r0,0) is
-   used for padding.  */
-#define ASM_OUTPUT_ALIGN_WITH_NOP(STREAM, LOG) \
-  fprintf (STREAM, "\t.align\t%d,54525952,4\n", (LOG))
-
 /* This is how to output an assembler line to advance the location
    counter by SIZE bytes.  */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-10-17  2:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-17  2:08 [gcc r14-4674] LoongArch: Delete macro definition ASM_OUTPUT_ALIGN_WITH_NOP LuluCheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).