[gcc r14-4750] ada: Seize opportunity to reuse List_Length

[gcc r14-4750] ada: Seize opportunity to reuse List_Length

[Marc Poulhi?s]

https://gcc.gnu.org/g:0c29a990a645e24d48bf06adb7e1dca104b79335

commit r14-4750-g0c29a990a645e24d48bf06adb7e1dca104b79335
Author: Ronan Desplanques <desplanques@adacore.com>
Date:   Fri Sep 29 11:25:18 2023 +0200

    ada: Seize opportunity to reuse List_Length
    
    This patch is intended as a readability improvement. It doesn't
    change the behavior of the compiler.
    
    gcc/ada/
    
            * sem_ch3.adb (Constrain_Array): Replace manual list length
            computation by call to List_Length.

Diff:
---
 gcc/ada/sem_ch3.adb | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/gcc/ada/sem_ch3.adb b/gcc/ada/sem_ch3.adb
index c79d323395f3..e92b46fa6f6f 100644
--- a/gcc/ada/sem_ch3.adb
+++ b/gcc/ada/sem_ch3.adb
@@ -13809,7 +13809,7 @@ package body Sem_Ch3 is
       Suffix      : Character)
    is
       C                     : constant Node_Id := Constraint (SI);
-      Number_Of_Constraints : Nat := 0;
+      Number_Of_Constraints : constant Nat := List_Length (Constraints (C));
       Index                 : Node_Id;
       S, T                  : Entity_Id;
       Constraint_OK         : Boolean := True;
@@ -13835,12 +13835,6 @@ package body Sem_Ch3 is
          Constraint_OK := False;
 
       else
-         S := First (Constraints (C));
-         while Present (S) loop
-            Number_Of_Constraints := Number_Of_Constraints + 1;
-            Next (S);
-         end loop;
-
          --  In either case, the index constraint must provide a discrete
          --  range for each index of the array type and the type of each
          --  discrete range must be the same as that of the corresponding