public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/aoliva/heads/testme)] hardcfr: fix indirect jump
@ 2023-10-20  3:48 Alexandre Oliva
  0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Oliva @ 2023-10-20  3:48 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:9231203d6d72f1a9e10e564fc4ebd6e7abb74c9f

commit 9231203d6d72f1a9e10e564fc4ebd6e7abb74c9f
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Thu Oct 19 02:52:45 2023 -0300

    hardcfr: fix indirect jump

Diff:
---
 gcc/gimple-harden-control-flow.cc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gcc/gimple-harden-control-flow.cc b/gcc/gimple-harden-control-flow.cc
index ac4a329ebad1..546837a450b8 100644
--- a/gcc/gimple-harden-control-flow.cc
+++ b/gcc/gimple-harden-control-flow.cc
@@ -1321,9 +1321,13 @@ pass_harden_control_flow_redundancy::execute (function *fun)
 		   || bb == bb_eh_cleanup)
 		: (!is_a <gcall *> (stmt)
 		   || !gimple_call_noreturn_p (stmt))
-		? (/* Catch cases in which successors would be
+		? (stmt_can_make_abnormal_goto (stmt)
+		   /* ??? Check before indirect nonlocal goto, or
+		      calls thereof?  */
+		   ? false
+		   /* Catch cases in which successors would be
 		      expected.  */
-		   gcc_unreachable (), false)
+		   : (gcc_unreachable (), false))
 		: (!flag_exceptions
 		   || gimple_call_nothrow_p (as_a <gcall *> (stmt)))
 		? check_before_nothrow_noreturn_calls

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [gcc(refs/users/aoliva/heads/testme)] hardcfr: fix indirect jump
@ 2023-09-29 22:11 Alexandre Oliva
  0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Oliva @ 2023-09-29 22:11 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:5a047ddab777aa7f335a50aa982ebb3697cf86a8

commit 5a047ddab777aa7f335a50aa982ebb3697cf86a8
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Mon Jul 3 18:09:34 2023 -0300

    hardcfr: fix indirect jump

Diff:
---
 gcc/gimple-harden-control-flow.cc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gcc/gimple-harden-control-flow.cc b/gcc/gimple-harden-control-flow.cc
index ac4a329ebad..546837a450b 100644
--- a/gcc/gimple-harden-control-flow.cc
+++ b/gcc/gimple-harden-control-flow.cc
@@ -1321,9 +1321,13 @@ pass_harden_control_flow_redundancy::execute (function *fun)
 		   || bb == bb_eh_cleanup)
 		: (!is_a <gcall *> (stmt)
 		   || !gimple_call_noreturn_p (stmt))
-		? (/* Catch cases in which successors would be
+		? (stmt_can_make_abnormal_goto (stmt)
+		   /* ??? Check before indirect nonlocal goto, or
+		      calls thereof?  */
+		   ? false
+		   /* Catch cases in which successors would be
 		      expected.  */
-		   gcc_unreachable (), false)
+		   : (gcc_unreachable (), false))
 		: (!flag_exceptions
 		   || gimple_call_nothrow_p (as_a <gcall *> (stmt)))
 		? check_before_nothrow_noreturn_calls

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [gcc(refs/users/aoliva/heads/testme)] hardcfr: fix indirect jump
@ 2023-06-29 18:42 Alexandre Oliva
  0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Oliva @ 2023-06-29 18:42 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:fe2e54ad3bdde9b6a52e389ad9d8c5f8f5e2878f

commit fe2e54ad3bdde9b6a52e389ad9d8c5f8f5e2878f
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Thu Jun 29 15:38:13 2023 -0300

    hardcfr: fix indirect jump

Diff:
---
 gcc/gimple-harden-control-flow.cc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gcc/gimple-harden-control-flow.cc b/gcc/gimple-harden-control-flow.cc
index ac4a329ebad..546837a450b 100644
--- a/gcc/gimple-harden-control-flow.cc
+++ b/gcc/gimple-harden-control-flow.cc
@@ -1321,9 +1321,13 @@ pass_harden_control_flow_redundancy::execute (function *fun)
 		   || bb == bb_eh_cleanup)
 		: (!is_a <gcall *> (stmt)
 		   || !gimple_call_noreturn_p (stmt))
-		? (/* Catch cases in which successors would be
+		? (stmt_can_make_abnormal_goto (stmt)
+		   /* ??? Check before indirect nonlocal goto, or
+		      calls thereof?  */
+		   ? false
+		   /* Catch cases in which successors would be
 		      expected.  */
-		   gcc_unreachable (), false)
+		   : (gcc_unreachable (), false))
 		: (!flag_exceptions
 		   || gimple_call_nothrow_p (as_a <gcall *> (stmt)))
 		? check_before_nothrow_noreturn_calls

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-20  3:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-20  3:48 [gcc(refs/users/aoliva/heads/testme)] hardcfr: fix indirect jump Alexandre Oliva
  -- strict thread matches above, loose matches on Subject: below --
2023-09-29 22:11 Alexandre Oliva
2023-06-29 18:42 Alexandre Oliva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).