public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-4882] i386: Fix unprotected REGNO in aeswidekl_operation
@ 2023-10-24 10:03 Richard Sandiford
  0 siblings, 0 replies; only message in thread
From: Richard Sandiford @ 2023-10-24 10:03 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:cc4779559bea982f9307a8bc1cb017b8eda28d6d

commit r14-4882-gcc4779559bea982f9307a8bc1cb017b8eda28d6d
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Tue Oct 24 11:03:21 2023 +0100

    i386: Fix unprotected REGNO in aeswidekl_operation
    
    I hit an ICE in aeswidekl_operation while testing the late-combine
    pass on x86.  The predicate tested REGNO without first testing REG_P.
    
    gcc/
            * config/i386/predicates.md (aeswidekl_operation): Protect
            REGNO check with REG_P.

Diff:
---
 gcc/config/i386/predicates.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/config/i386/predicates.md b/gcc/config/i386/predicates.md
index ef49efdbde58..e3d55f0c5022 100644
--- a/gcc/config/i386/predicates.md
+++ b/gcc/config/i386/predicates.md
@@ -2260,6 +2260,7 @@
 	  || GET_CODE (SET_SRC (elt)) != UNSPEC_VOLATILE
 	  || GET_MODE (SET_SRC (elt)) != V2DImode
 	  || XVECLEN (SET_SRC (elt), 0) != 1
+	  || !REG_P (XVECEXP (SET_SRC (elt), 0, 0))
 	  || REGNO (XVECEXP (SET_SRC (elt), 0, 0)) != GET_SSE_REGNO (i))
 	return false;
     }

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2023-10-24 10:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-24 10:03 [gcc r14-4882] i386: Fix unprotected REGNO in aeswidekl_operation Richard Sandiford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).