public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-5586] LoongArch: Fix "-mexplict-relocs=none -mcmodel=medium" producing %call36 when the assembler does not
@ 2023-11-18 20:46 Xi Ruoyao
  0 siblings, 0 replies; only message in thread
From: Xi Ruoyao @ 2023-11-18 20:46 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:84c5dede83de84e0a06b018103be0b9ede5b04a1

commit r14-5586-g84c5dede83de84e0a06b018103be0b9ede5b04a1
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Sun Nov 19 01:41:12 2023 +0800

    LoongArch: Fix "-mexplict-relocs=none -mcmodel=medium" producing %call36 when the assembler does not support it
    
    Even if !HAVE_AS_SUPPORT_CALL36, const_call_insn_operand should still
    return false when -mexplict-relocs=none -mcmodel=medium to make
    loongarch_legitimize_call_address emit la.local or la.global.
    
    gcc/ChangeLog:
    
            * config/loongarch/predicates.md (const_call_insn_operand):
            Remove buggy "HAVE_AS_SUPPORT_CALL36" conditions.  Change "1" to
            "true" to make the coding style consistent.

Diff:
---
 gcc/config/loongarch/predicates.md | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gcc/config/loongarch/predicates.md b/gcc/config/loongarch/predicates.md
index 56f7c48e126..d02e846cb12 100644
--- a/gcc/config/loongarch/predicates.md
+++ b/gcc/config/loongarch/predicates.md
@@ -444,21 +444,19 @@
     case SYMBOL_PCREL:
       if (TARGET_CMODEL_EXTREME
 	  || (TARGET_CMODEL_MEDIUM
-	      && HAVE_AS_SUPPORT_CALL36
 	      && (la_opt_explicit_relocs == EXPLICIT_RELOCS_NONE)))
 	return false;
       else
-	return 1;
+	return true;
 
     case SYMBOL_GOT_DISP:
       if (TARGET_CMODEL_EXTREME
 	  || !flag_plt
 	  || (flag_plt && TARGET_CMODEL_MEDIUM
-	      && HAVE_AS_SUPPORT_CALL36
 	      && (la_opt_explicit_relocs == EXPLICIT_RELOCS_NONE)))
 	return false;
       else
-	return 1;
+	return true;
 
     default:
       return false;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-11-18 20:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-18 20:46 [gcc r14-5586] LoongArch: Fix "-mexplict-relocs=none -mcmodel=medium" producing %call36 when the assembler does not Xi Ruoyao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).