public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-6208] driver: Fix bootstrap with --enable-default-pie
@ 2023-12-06 8:54 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2023-12-06 8:54 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:895a70f012b8c1b8e80ecc584c1d7ded014bc2bc
commit r14-6208-g895a70f012b8c1b8e80ecc584c1d7ded014bc2bc
Author: Jakub Jelinek <jakub@redhat.com>
Date: Wed Dec 6 09:54:03 2023 +0100
driver: Fix bootstrap with --enable-default-pie
On IRC Iain mentioned bootstrap is broken for him presumably since
r14-5791 -fhardened addition. I think it is only a problem with
--enable-default-pie when the case OPT_pie: wants to fall through
into case OPT_r: and warns.
Before the patch validated = true; was set up if ENABLE_DEFAULT_PIE
for OPT_pie, and for -fhardened as documented I think we want to
set any_link_options_p = true; for it too:
/* True if -r, -shared, -pie, or -no-pie were specified on the command
line. */
static bool any_link_options_p;
2023-12-06 Jakub Jelinek <jakub@redhat.com>
* gcc.cc (driver_handle_option): Add /* FALLTHROUGH */ comment
between OPT_pie and OPT_r cases.
Diff:
---
gcc/gcc.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/gcc.cc b/gcc/gcc.cc
index 9f21ad9453e..03ec6e1cb2f 100644
--- a/gcc/gcc.cc
+++ b/gcc/gcc.cc
@@ -4617,6 +4617,7 @@ driver_handle_option (struct gcc_options *opts,
/* -pie is turned on by default. */
validated = true;
#endif
+ /* FALLTHROUGH */
case OPT_r:
case OPT_shared:
case OPT_no_pie:
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-12-06 8:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-06 8:54 [gcc r14-6208] driver: Fix bootstrap with --enable-default-pie Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).