public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-8412] LoongArch: Disable TLS type symbols from generating non-zero offsets.
@ 2024-01-25 7:38 LuluCheng
0 siblings, 0 replies; only message in thread
From: LuluCheng @ 2024-01-25 7:38 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:0801a88af40e4bb41c240788a2365ca1e30e281a
commit r14-8412-g0801a88af40e4bb41c240788a2365ca1e30e281a
Author: Lulu Cheng <chenglulu@loongson.cn>
Date: Tue Jan 23 11:28:09 2024 +0800
LoongArch: Disable TLS type symbols from generating non-zero offsets.
TLS gd ld and ie type symbols will generate corresponding GOT entries,
so non-zero offsets cannot be generated.
The address of TLS le type symbol+addend is not implemented in binutils,
so non-zero offset is not generated here for the time being.
gcc/ChangeLog:
* config/loongarch/loongarch.cc (loongarch_symbolic_constant_p):
For symbols of type tls, non-zero Offset is not generated.
Diff:
---
gcc/config/loongarch/loongarch.cc | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc
index 072c68d97e3..da22fd63e91 100644
--- a/gcc/config/loongarch/loongarch.cc
+++ b/gcc/config/loongarch/loongarch.cc
@@ -1924,11 +1924,7 @@ loongarch_symbolic_constant_p (rtx x, enum loongarch_symbol_type *symbol_type)
x = UNSPEC_ADDRESS (x);
}
else if (SYMBOL_REF_P (x) || LABEL_REF_P (x))
- {
- *symbol_type = loongarch_classify_symbol (x);
- if (*symbol_type == SYMBOL_TLS)
- return true;
- }
+ *symbol_type = loongarch_classify_symbol (x);
else
return false;
@@ -1939,17 +1935,21 @@ loongarch_symbolic_constant_p (rtx x, enum loongarch_symbol_type *symbol_type)
relocations. */
switch (*symbol_type)
{
- case SYMBOL_TLS_IE:
- case SYMBOL_TLS_LE:
- case SYMBOL_TLSGD:
- case SYMBOL_TLSLDM:
case SYMBOL_PCREL:
case SYMBOL_PCREL64:
/* GAS rejects offsets outside the range [-2^31, 2^31-1]. */
return sext_hwi (INTVAL (offset), 32) == INTVAL (offset);
+ /* The following symbol types do not allow non-zero offsets. */
case SYMBOL_GOT_DISP:
+ case SYMBOL_TLS_IE:
+ case SYMBOL_TLSGD:
+ case SYMBOL_TLSLDM:
case SYMBOL_TLS:
+ /* From an implementation perspective, tls_le symbols are allowed to
+ have non-zero offsets, but currently binutils has not added support,
+ so the generation of non-zero offsets is prohibited here. */
+ case SYMBOL_TLS_LE:
return false;
}
gcc_unreachable ();
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-25 7:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-25 7:38 [gcc r14-8412] LoongArch: Disable TLS type symbols from generating non-zero offsets LuluCheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).