public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-8435] [PR113526][LRA]: Fixing asm-flag-1.c failure on ARM
@ 2024-01-25 19:46 Vladimir Makarov
0 siblings, 0 replies; only message in thread
From: Vladimir Makarov @ 2024-01-25 19:46 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:476226290dba8cd7f3e9f4e3f0185b58903db8cd
commit r14-8435-g476226290dba8cd7f3e9f4e3f0185b58903db8cd
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date: Thu Jan 25 14:41:17 2024 -0500
[PR113526][LRA]: Fixing asm-flag-1.c failure on ARM
My recent patch for PR113356 results in failure asm-flag-1.c test on arm.
After the patch LRA treats asm operand pseudos as general regs. There
are too many such operands and LRA can not assign hard regs to all
operand pseudos. Actually we should not assign hard regs to the
operand pseudo at all. The following patch fixes this.
gcc/ChangeLog:
PR target/113526
* lra-constraints.cc (curr_insn_transform): Change class even for
spilled pseudo successfully matched with with NO_REGS.
Diff:
---
gcc/lra-constraints.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/lra-constraints.cc b/gcc/lra-constraints.cc
index 3379b88ff22e..0ae81c1ff9cb 100644
--- a/gcc/lra-constraints.cc
+++ b/gcc/lra-constraints.cc
@@ -4498,10 +4498,10 @@ curr_insn_transform (bool check_only_p)
registers for other pseudos referenced in the insn. The most
common case of this is a scratch register which will be
transformed to scratch back at the end of LRA. */
- && lra_get_regno_hard_regno (regno) >= 0
&& bitmap_single_bit_set_p (&lra_reg_info[regno].insn_bitmap))
{
- lra_change_class (regno, NO_REGS, " Change to", true);
+ if (lra_get_allocno_class (regno) != NO_REGS)
+ lra_change_class (regno, NO_REGS, " Change to", true);
reg_renumber[regno] = -1;
}
/* We can do an optional reload. If the pseudo got a hard
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-25 19:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-25 19:46 [gcc r14-8435] [PR113526][LRA]: Fixing asm-flag-1.c failure on ARM Vladimir Makarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).