public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-8497] middle-end/113622 - allow .VEC_SET and .VEC_EXTRACT for global hard regs
@ 2024-01-29 13:31 Richard Biener
  0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2024-01-29 13:31 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:96bc048d78f804bac0fa7b2ca3b6dd3a04c68217

commit r14-8497-g96bc048d78f804bac0fa7b2ca3b6dd3a04c68217
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Jan 29 09:47:31 2024 +0100

    middle-end/113622 - allow .VEC_SET and .VEC_EXTRACT for global hard regs
    
    The following expands .VEC_SET and .VEC_EXTRACT instruction selection
    to global hard registers, not only automatic variables (possibly)
    promoted to registers.  This can avoid some ICEs later and create
    better code.
    
            PR middle-end/113622
            * gimple-isel.cc (gimple_expand_vec_set_extract_expr):
            Also allow DECL_HARD_REGISTER variables.
    
            * gcc.target/i386/pr113622-1.c: New testcase.

Diff:
---
 gcc/gimple-isel.cc                         |  3 ++-
 gcc/testsuite/gcc.target/i386/pr113622-1.c | 12 ++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/gcc/gimple-isel.cc b/gcc/gimple-isel.cc
index 7e2392ecd387..54c1801038ba 100644
--- a/gcc/gimple-isel.cc
+++ b/gcc/gimple-isel.cc
@@ -104,7 +104,8 @@ gimple_expand_vec_set_extract_expr (struct function *fun,
       machine_mode outermode = TYPE_MODE (TREE_TYPE (view_op0));
       machine_mode extract_mode = TYPE_MODE (TREE_TYPE (ref));
 
-      if (auto_var_in_fn_p (view_op0, fun->decl)
+      if ((auto_var_in_fn_p (view_op0, fun->decl)
+	   || (VAR_P (view_op0) && DECL_HARD_REGISTER (view_op0)))
 	  && !TREE_ADDRESSABLE (view_op0)
 	  && ((!is_extract && can_vec_set_var_idx_p (outermode))
 	      || (is_extract
diff --git a/gcc/testsuite/gcc.target/i386/pr113622-1.c b/gcc/testsuite/gcc.target/i386/pr113622-1.c
new file mode 100644
index 000000000000..d3a51cd81dca
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr113622-1.c
@@ -0,0 +1,12 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -mavx512f -w" } */
+
+typedef float __attribute__ ((vector_size (64))) vec;
+register vec a asm("zmm5"), b asm("zmm6"), c asm("zmm7");
+
+void
+test (void)
+{
+  for (int i = 0; i < 8; i++)
+    c[i] = a[i] < b[i] ? 0.1 : 0.2;
+}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-01-29 13:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-29 13:31 [gcc r14-8497] middle-end/113622 - allow .VEC_SET and .VEC_EXTRACT for global hard regs Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).