public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-10155] tree-optimization/113896 - reduction of permuted external vector
@ 2024-02-14 11:43 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2024-02-14 11:43 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:2f16c53558d01135f0f78cf78a2f722b774684d7
commit r12-10155-g2f16c53558d01135f0f78cf78a2f722b774684d7
Author: Richard Biener <rguenther@suse.de>
Date: Tue Feb 13 13:43:44 2024 +0100
tree-optimization/113896 - reduction of permuted external vector
The following fixes eliding of the permutation of a BB reduction
of an existing vector which breaks materialization of live lanes
as we fail to permute the SLP_TREE_SCALAR_STMTS vector.
PR tree-optimization/113896
* tree-vect-slp.cc (vect_optimize_slp): Permute
SLP_TREE_SCALAR_STMTS when eliding a permuation in a
VEC_PERM node we need to preserve because it wraps an
extern vector.
* g++.dg/torture/pr113896.C: New testcase.
Diff:
---
gcc/testsuite/g++.dg/torture/pr113896.C | 35 +++++++++++++++++++++++++++++++++
gcc/tree-vect-slp.cc | 9 +++++++++
2 files changed, 44 insertions(+)
diff --git a/gcc/testsuite/g++.dg/torture/pr113896.C b/gcc/testsuite/g++.dg/torture/pr113896.C
new file mode 100644
index 000000000000..534c1c2e1cce
--- /dev/null
+++ b/gcc/testsuite/g++.dg/torture/pr113896.C
@@ -0,0 +1,35 @@
+// { dg-do run }
+// { dg-additional-options "-ffast-math" }
+
+double a1 = 1.0;
+double a2 = 1.0;
+
+void __attribute__((noipa))
+f(double K[2], bool b)
+{
+ double A[] = {
+ b ? a1 : a2,
+ 0,
+ 0,
+ 0
+ };
+
+ double sum{};
+ for(double a : A) sum += a;
+ for(double& a : A) a /= sum;
+
+ if (b) {
+ K[0] = A[0]; // 1.0
+ K[1] = A[1]; // 0.0
+ } else {
+ K[0] = A[0] + A[1];
+ }
+}
+
+int main()
+{
+ double K[2]{};
+ f(K, true);
+ if (K[0] != 1. || K[1] != 0.)
+ __builtin_abort ();
+}
diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc
index af477c31aa3d..b3e3d9e70094 100644
--- a/gcc/tree-vect-slp.cc
+++ b/gcc/tree-vect-slp.cc
@@ -4058,6 +4058,15 @@ vect_optimize_slp (vec_info *vinfo)
{
/* Preserve the special VEC_PERM we use to shield existing
vector defs from the rest. But make it a no-op. */
+ auto_vec<stmt_vec_info, 64> saved;
+ saved.create (SLP_TREE_SCALAR_STMTS (old).length ());
+ for (unsigned i = 0;
+ i < SLP_TREE_SCALAR_STMTS (old).length (); ++i)
+ saved.quick_push (SLP_TREE_SCALAR_STMTS (old)[i]);
+ for (unsigned i = 0;
+ i < SLP_TREE_SCALAR_STMTS (old).length (); ++i)
+ SLP_TREE_SCALAR_STMTS (old)[i]
+ = saved[SLP_TREE_LANE_PERMUTATION (old)[i].second];
unsigned i = 0;
for (std::pair<unsigned, unsigned> &p
: SLP_TREE_LANE_PERMUTATION (old))
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-14 11:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-14 11:43 [gcc r12-10155] tree-optimization/113896 - reduction of permuted external vector Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).