public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-8980] tree-optimization/113910 - huge compile time during PTA
@ 2024-02-14 14:51 Richard Biener
  0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2024-02-14 14:51 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:ad7a365aaccecd23ea287c7faaab9c7bd50b944a

commit r14-8980-gad7a365aaccecd23ea287c7faaab9c7bd50b944a
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Feb 14 12:33:13 2024 +0100

    tree-optimization/113910 - huge compile time during PTA
    
    For the testcase in PR113910 we spend a lot of time in PTA comparing
    bitmaps for looking up equivalence class members.  This points to
    the very weak bitmap_hash function which effectively hashes set
    and a subset of not set bits.
    
    The major problem with it is that it simply truncates the
    BITMAP_WORD sized intermediate hash to hashval_t which is
    unsigned int, effectively not hashing half of the bits.
    
    This reduces the compile-time for the testcase from tens of minutes
    to 42 seconds and PTA time from 99% to 46%.
    
            PR tree-optimization/113910
            * bitmap.cc (bitmap_hash): Mix the full element "hash" to
            the hashval_t hash.

Diff:
---
 gcc/bitmap.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/bitmap.cc b/gcc/bitmap.cc
index 6cf326bca5a8..459e32c1ad18 100644
--- a/gcc/bitmap.cc
+++ b/gcc/bitmap.cc
@@ -2706,7 +2706,7 @@ bitmap_hash (const_bitmap head)
       for (ix = 0; ix != BITMAP_ELEMENT_WORDS; ix++)
 	hash ^= ptr->bits[ix];
     }
-  return (hashval_t)hash;
+  return iterative_hash (&hash, sizeof (hash), 0);
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-02-14 14:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-14 14:51 [gcc r14-8980] tree-optimization/113910 - huge compile time during PTA Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).