public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/meissner/heads/work158-future)] Update ChangeLog.*
@ 2024-02-15 22:37 Michael Meissner
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Meissner @ 2024-02-15 22:37 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:cd30ce15cad0baf56a9e3708df2188d8bb6770e1

commit cd30ce15cad0baf56a9e3708df2188d8bb6770e1
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Thu Feb 15 17:37:32 2024 -0500

    Update ChangeLog.*

Diff:
---
 gcc/ChangeLog.future | 105 +++++++++++++++++++++++++++++++++------------------
 1 file changed, 68 insertions(+), 37 deletions(-)

diff --git a/gcc/ChangeLog.future b/gcc/ChangeLog.future
index 0696de9149be..0ca84014bad0 100644
--- a/gcc/ChangeLog.future
+++ b/gcc/ChangeLog.future
@@ -1,74 +1,86 @@
-==================== Branch work158-future, patch #107 ====================
+==================== Branch work158-future, patch #116 ====================
 
-Enable using vector pair load/store for -mcpu=future
+Add configure support for PowerPC future.
 
-2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+2024-02-15  Michael Meissner  <meissner@linux.ibm.com>
 
 gcc/
 
-	* config/rs6000/rs6000-cpus.def (ISA_FUTURE_MASKS_SERVER): Turn on
-	-mblock-ops-vector-pair for -mcpu=future.
+	* config.gcc (powerpc*-*-*, rs6000-*-*): Add support for
+	--with-cpu=future.
 
-==================== Branch work158-future, patch #106 ====================
+==================== Branch work158-future, patch #115 ====================
 
-Set future machine type in assembler if -mcpu=future
+Enable using vector pair load/store for -mcpu=future
 
-2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+Late in the development of power10, we discovered that there were some issues
+in using load vector pair and store vector pair instructions to do memory
+copies, so the defaults were modified to not use these instructions.  This
+patch re-enables using load and store vector pair instructions.
+
+Previously the -mblock-ops-vector-pair switch was not set in POWERPC_MASKS.
+This means the option was not reset if the cpu was changed via target
+attributes or targt pragmas.  I added this mask to POWERPC_MASKS since the
+option is set via -mcpu=future.
+
+2024-02-15  Michael Meissner  <meissner@linux.ibm.com>
 
 gcc/
 
-	* config/rs6000/rs6000.cc (rs6000_machine_from_flags): Output .machine
-	future if -mcpu=future.
+	* config/rs6000/rs6000-cpus.def (ISA_FUTURE_MASKS_SERVER): Turn on
+	-mblock-ops-vector-pair for -mcpu=future.
+	(POWERPC_MASKS): Add -mblock-ops-vector-pair.
 
-==================== Branch work158-future, patch #105 ====================
+==================== Branch work158-future, patch #114 ====================
 
-Make -mtune=future be the same as -mtune=power10.
+Set future machine type in assembler if -mcpu=future
 
-2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+This patch uses the .machine directive to tell the assembler to use any
+possible future instructions.
+
+2024-02-15  Michael Meissner  <meissner@linux.ibm.com>
 
 gcc/
 
-	* config/rs6000/rs6000.cc (rs6000_option_override_internal): Make
-	-mtune=future become -mtune=power10.
+	* config/rs6000/rs6000.cc (rs6000_machine_from_flags): Output .machine
+	future if -mcpu=future.
 
-==================== Branch work158-future, patch #104 ====================
+==================== Branch work158-future, patch #113 ====================
 
 Pass -mfuture to assembler if -mcpu=future.
 
-2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+This patch passes -mfuture to the assembler if the user used -mcpu=future.
+
+2024-02-15  Michael Meissner  <meissner@linux.ibm.com>
 
 gcc/
 
 	* config/rs6000/rs6000.h (ASM_CPU_SPEC): If -mcpu=future, pass -mfuture
 	to the assembler.
 
-==================== Branch work158-future, patch #103 ====================
+==================== Branch work158-future, patch #112 ====================
 
 Define _ARCH_PWR_FUTURE if -mcpu=future.
 
-2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+This patch defines _ARCH_PWR_FUTURE if -mcpu=future was used.
+
+2024-02-15  Michael Meissner  <meissner@linux.ibm.com>
 
 gcc/
 
 	* config/rs6000/rs6000-c.cc (rs6000_target_modify_macros): Define
 	_ARCH_PWR_FUTURE if -mcpu=future.
 
-==================== Branch work158-future, patch #102 ====================
-
-Add debugging for -mcpu=future
-
-2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
-
-gcc/
-
-	* config/rs6000/rs6000.cc (rs6000_opt_masks): Add entry to print out
-	-mfuture in the isa flags.
-
-==================== Branch work158-future, patch #101 ====================
+==================== Branch work158-future, patch #111 ====================
 
 Add initial -mcpu=future support.
 
-2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+This patch adds the basic support for -mcpu=future, which is a framework to add
+support for possible future PowerPCs.  Until there are changes for a possible
+future PowerPC, -mcpu=future and -mtune=future default to power10.  An ISA bit
+is set to denote possible future instructions are enabled.
+
+2024-02-15  Michael Meissner  <meissner@linux.ibm.com>
 
 gcc/
 
@@ -76,11 +88,30 @@ gcc/
 	bits for -mcpu=future.
 	(POWERPC_MASKS): Add -mfuture mask.
 	(future cpu): Add -mcpu=future.
-	* config/rs6000/rs6000-opts.h (PROCESSOR_FUTURE): New processor type.
-	* config/rs6000/rs6000-tables.opt (rs6000_cpu_opt_value): Likewise.
-	* config/rs6000/rs6000.md (cpu attribute): Likewise.
-	* config/rs6000/rs6000.opt (-mfuture): New insert mask for -mcpu=future.
-	* doc/invoke.texi (PowerPC options): Add -mcpu=future.
+	* config/rs6000/rs6000-opts.h (PROCESSOR_FUTURE): Map PROCESSOR_FUTURE
+	into PROCESSOR_POWER10 until there are differences that necessate a new
+	processor enumeration.
+	* config/rs6000/rs6000-tables.opt (rs6000_cpu_opt_value): Add future
+	variant.
+	* config/rs6000/rs6000.cc (rs6000_opt_masks): Add printing -mfuture if
+	-mdebug=reg is used.  Do not allow it to be set with a target attribute
+	or pragma.
+	* config/rs6000/rs6000.opt (-mfuture): New ISA bit for -mcpu=future.
+	* doc/invoke.texi (PowerPC options): Document -mcpu=future.
+
+==================== Branch work158-future, patch #107 was reverted ====================
+
+==================== Branch work158-future, patch #106 was reverted ====================
+
+==================== Branch work158-future, patch #105 was reverted ====================
+
+==================== Branch work158-future, patch #104 was reverted ====================
+
+==================== Branch work158-future, patch #103 was reverted ====================
+
+==================== Branch work158-future, patch #102 was reverted ====================
+
+==================== Branch work158-future, patch #101 was reverted ====================
 
 ==================== Branch work158-future, patch #2 from work158 ====================

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [gcc(refs/users/meissner/heads/work158-future)] Update ChangeLog.*
@ 2024-02-10  5:52 Michael Meissner
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Meissner @ 2024-02-10  5:52 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:e5f8b110d8f043f558a7a6450ff0da3137d3dca6

commit e5f8b110d8f043f558a7a6450ff0da3137d3dca6
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Sat Feb 10 00:52:19 2024 -0500

    Update ChangeLog.*

Diff:
---
 gcc/ChangeLog.future | 236 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 236 insertions(+)

diff --git a/gcc/ChangeLog.future b/gcc/ChangeLog.future
index 9c6c39cc0333..0696de9149be 100644
--- a/gcc/ChangeLog.future
+++ b/gcc/ChangeLog.future
@@ -1,5 +1,241 @@
+==================== Branch work158-future, patch #107 ====================
+
+Enable using vector pair load/store for -mcpu=future
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000-cpus.def (ISA_FUTURE_MASKS_SERVER): Turn on
+	-mblock-ops-vector-pair for -mcpu=future.
+
+==================== Branch work158-future, patch #106 ====================
+
+Set future machine type in assembler if -mcpu=future
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000.cc (rs6000_machine_from_flags): Output .machine
+	future if -mcpu=future.
+
+==================== Branch work158-future, patch #105 ====================
+
+Make -mtune=future be the same as -mtune=power10.
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000.cc (rs6000_option_override_internal): Make
+	-mtune=future become -mtune=power10.
+
+==================== Branch work158-future, patch #104 ====================
+
+Pass -mfuture to assembler if -mcpu=future.
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000.h (ASM_CPU_SPEC): If -mcpu=future, pass -mfuture
+	to the assembler.
+
+==================== Branch work158-future, patch #103 ====================
+
+Define _ARCH_PWR_FUTURE if -mcpu=future.
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000-c.cc (rs6000_target_modify_macros): Define
+	_ARCH_PWR_FUTURE if -mcpu=future.
+
+==================== Branch work158-future, patch #102 ====================
+
+Add debugging for -mcpu=future
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000.cc (rs6000_opt_masks): Add entry to print out
+	-mfuture in the isa flags.
+
+==================== Branch work158-future, patch #101 ====================
+
+Add initial -mcpu=future support.
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000-cpus.def (ISA_FUTURE_MASKS_SERVER): New option
+	bits for -mcpu=future.
+	(POWERPC_MASKS): Add -mfuture mask.
+	(future cpu): Add -mcpu=future.
+	* config/rs6000/rs6000-opts.h (PROCESSOR_FUTURE): New processor type.
+	* config/rs6000/rs6000-tables.opt (rs6000_cpu_opt_value): Likewise.
+	* config/rs6000/rs6000.md (cpu attribute): Likewise.
+	* config/rs6000/rs6000.opt (-mfuture): New insert mask for -mcpu=future.
+	* doc/invoke.texi (PowerPC options): Add -mcpu=future.
+
+==================== Branch work158-future, patch #2 from work158 ====================
+
+PR target/112886, Add %S<n> to print_operand for vector pair support.
+
+In looking at support for load vector pair and store vector pair for the
+PowerPC in GCC, I noticed that we were missing a print_operand output modifier
+if you are dealing with vector pairs to print the 2nd register in the vector
+pair.
+
+If the instruction inside of the asm used the Altivec encoding, then we could
+use the %L<n> modifier:
+
+	__vector_pair *p, *q, *r;
+	// ...
+	__asm__ ("vaddudm %0,%1,%2\n\tvaddudm %L0,%L1,%L2"
+		 : "=v" (*p)
+		 : "v" (*q), "v" (*r));
+
+Likewise if we know the value to be in a tradiational FPR register, %L<n> will
+work for instructions that use the VSX encoding:
+
+	__vector_pair *p, *q, *r;
+	// ...
+	__asm__ ("xvadddp %x0,%x1,%x2\n\txvadddp %L0,%L1,%L2"
+		 : "=f" (*p)
+		 : "f" (*q), "f" (*r));
+
+But if have a value that is in a traditional Altivec register, and the
+instruction uses the VSX encoding, %L<n> will a value between 0 and 31, when it
+should give a value between 32 and 63.
+
+This patch adds %S<n> that acts like %x<n>, except that it adds 1 to the
+register number.
+
+This is version 2 of the patch.  The only difference is I made the test case
+simpler to read.
+
+I have tested this on power10 and power9 little endian systems and on a power9
+big endian system.  There were no regressions in the patch.  Can I apply it to
+the trunk?
+
+It would be nice if I could apply it to the open branches.  Can I backport it
+after a burn-in period?
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	PR target/112886
+	* config/rs6000/rs6000.cc (print_operand): Add %S<n> output modifier.
+	* doc/md.texi (Modifiers): Mention %S can be used like %x.
+
+gcc/testsuite/
+
+	PR target/112886
+	* /gcc.target/powerpc/pr112886.c: New test.
+
+==================== Branch work158-future, patch #1 from work158 ====================
+
+Power10: Add options to disable load and store vector pair.
+
+This is version 2 of the patch to add -mno-load-vector-pair and
+-mno-store-vector-pair undocumented tuning switches.
+
+The differences between the first version of the patch and this version is that
+I added explicit RTL abi attributes for when the compiler can generate the load
+vector pair and store vector pair instructions.  By having this attribute, the
+movoo insn has separate alternatives for when we generate the instruction and
+when we want to split the instruction into 2 separate vector loads or stores.
+
+In the first version of the patch, I had previously provided built-in functions
+that would always generate load vector pair and store vector pair instructions
+even if these instructions are normally disabled.  I found these built-ins
+weren't specified like the other vector pair built-ins, and I didn't include
+documentation for the built-in functions.  If we want such built-in functions,
+we can add them as a separate patch later.
+
+In addition, since both versions of the patch adds #pragma target and attribute
+support to change the results for individual functions, we can select on a
+function by function basis what the defaults for load/store vector pair is.
+
+The original text for the patch is:
+
+In working on some future patches that involve utilizing vector pair
+instructions, I wanted to be able to tune my program to enable or disable using
+the vector pair load or store operations while still keeping the other
+operations on the vector pair.
+
+This patch adds two undocumented tuning options.  The -mno-load-vector-pair
+option would tell GCC to generate two load vector instructions instead of a
+single load vector pair.  The -mno-store-vector-pair option would tell GCC to
+generate two store vector instructions instead of a single store vector pair.
+
+If either -mno-load-vector-pair is used, GCC will not generate the indexed
+stxvpx instruction.  Similarly if -mno-store-vector-pair is used, GCC will not
+generate the indexed lxvpx instruction.  The reason for this is to enable
+splitting the {,p}lxvp or {,p}stxvp instructions after reload without needing a
+scratch GPR register.
+
+The default for -mcpu=power10 is that both load vector pair and store vector
+pair are enabled.
+
+I added code so that the user code can modify these settings using either a
+'#pragma GCC target' directive or used __attribute__((__target__(...))) in the
+function declaration.
+
+I added tests for the switches, #pragma, and attribute options.
+
+I have built this on both little endian power10 systems and big endian power9
+systems doing the normal bootstrap and test.  There were no regressions in any
+of the tests, and the new tests passed.  Can I check this patch into the master
+branch?
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/mma.md (movoo): Add support for -mno-load-vector-pair and
+	-mno-store-vector-pair.
+	* config/rs6000/rs6000-cpus.def (OTHER_POWER10_MASKS): Add support for
+	-mload-vector-pair and -mstore-vector-pair.
+	(POWERPC_MASKS): Likewise.
+	* config/rs6000/rs6000.cc (rs6000_setup_reg_addr_masks): Only allow
+	indexed mode for OOmode if we are generating both load vector pair and
+	store vector pair instructions.
+	(rs6000_option_override_internal): Add support for -mno-load-vector-pair
+	and -mno-store-vector-pair.
+	(rs6000_opt_masks): Likewise.
+	* config/rs6000/rs6000.md (isa attribute): Add lxvp and stxvp
+	attributes.
+	(enabled attribute): Likewise.
+	* config/rs6000/rs6000.opt (-mload-vector-pair): New option.
+	(-mstore-vector-pair): Likewise.
+
+gcc/testsuite/
+
+	* gcc.target/powerpc/vector-pair-attribute.c: New test.
+	* gcc.target/powerpc/vector-pair-pragma.c: New test.
+	* gcc.target/powerpc/vector-pair-switch1.c: New test.
+	* gcc.target/powerpc/vector-pair-switch2.c: New test.
+	* gcc.target/powerpc/vector-pair-switch3.c: New test.
+	* gcc.target/powerpc/vector-pair-switch4.c: New test.
+
 ==================== Branch work158-future, baseline ====================
 
+Add ChangeLog.future and update REVISION.
+
+2024-02-09  Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* ChangeLog.future: New file for branch.
+	* REVISION: Update.
+
 2024-02-09   Michael Meissner  <meissner@linux.ibm.com>
 
 	Clone branch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-15 22:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-15 22:37 [gcc(refs/users/meissner/heads/work158-future)] Update ChangeLog.* Michael Meissner
  -- strict thread matches above, loose matches on Subject: below --
2024-02-10  5:52 Michael Meissner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).